Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1 @extension changes - add suppressions for upcoming deprecation warnings #32871

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

chrisradek
Copy link
Member

@chrisradek chrisradek commented Feb 26, 2025

microsoft/typespec#6078 updates @OpenAPI.extension to use value syntax. In the next release, current usage of model/tuple expressions will create a deprecation warning.

Suppressing deprecations instead of converting to value syntax (like in #32832) to give sdks time to upgrade once these changes are released.

Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Copy link

openapi-pipeline-app bot commented Feb 26, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Feb 26, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/computefleet/armcomputefleet https://apiview.dev/Assemblies/Review/d735ff32937b476cb8320846d8f090fb?revisionId=af7b62c29be743d68aec6aac64eb6030
Go sdk/resourcemanager/databasefleetmanager/armdatabasefleetmanager https://apiview.dev/Assemblies/Review/58c014775f244b0180cec1681999a7a2?revisionId=f8712eedd89743cb828bdc5844e92c3f
Go sdk/resourcemanager/databasewatcher/armdatabasewatcher https://apiview.dev/Assemblies/Review/4d1423121a9848d29f7c1f85d51ab24c?revisionId=74d44f5db7dc4202a29dc7ea92045df8
Go sdk/resourcemanager/deviceregistry/armdeviceregistry https://apiview.dev/Assemblies/Review/88a5b0711856485f90f77e2ab4ab9411?revisionId=3a7e045d8dc64d7fb215ad532552a66e
Go sdk/resourcemanager/devopsinfrastructure/armdevopsinfrastructure https://apiview.dev/Assemblies/Review/6f45301e365a498191b3b0e8522c7c20?revisionId=df98aa326a314b6d8cf497f7e53bcf45
Go sdk/resourcemanager/impactreporting/armimpactreporting There is no API change compared with the previous version
Go sdk/resourcemanager/iotoperations/armiotoperations https://apiview.dev/Assemblies/Review/e7201948d0214fdfa9767bfbe86b0bb9?revisionId=e5d1f72076094cc89e82e96e09d69424
Go sdk/resourcemanager/mongocluster/armmongocluster https://apiview.dev/Assemblies/Review/b4d2bfc01ecb45d69db8ed292bcdf07d?revisionId=55b531fcc4eb4c96a933de64e42cb1e4
Go sdk/resourcemanager/recoveryservicesdatareplication/armrecoveryservicesdatareplication https://apiview.dev/Assemblies/Review/502dc958b29b4a3aa47572685fafa521?revisionId=e2819fc3df5c43839b9626c64728117e
Go sdk/resourcemanager/servicenetworking/armservicenetworking https://apiview.dev/Assemblies/Review/dac0f14920064789802d4f9817062b17?revisionId=18aeccda2cd740a883daa6722b5110a7
Go sdk/resourcemanager/standbypool/armstandbypool There is no API change compared with the previous version
Go sdk/resourcemanager/terraform/armterraform https://apiview.dev/Assemblies/Review/503eaf6a29f042d992b397d076b83d9d?revisionId=ebdace0ff1164f95af38817b88f627a5
Go sdk/resourcemanager/trustedsigning/armtrustedsigning https://apiview.dev/Assemblies/Review/771cca5f112542e6b88cb4a067eed15e?revisionId=1f9b5145087d45998cf9de1eeaa58a25
Go sdk/resourcemanager/workloadssapvirtualinstance/armworkloadssapvirtualinstance https://apiview.dev/Assemblies/Review/4b0b418f02214b1cb1bd4429ea03b3c5?revisionId=5c7fb454ea8e46f89f1858f8f90c574e
.Net Azure.ResourceManager.AgriculturePlatform https://apiview.dev/Assemblies/Review/2f0a9b9baee9437bbd8036e664b89d6c?revisionId=4fd38a3931fe4737bb2f501242ed3f41
.Net Azure.ResourceManager.DatabaseFleetManager https://apiview.dev/Assemblies/Review/358fabb5a72e4fba8873eb17d6c9b31c?revisionId=709dbc25034c4143a8e80f55d80a0185
.Net Azure.ResourceManager.DatabaseWatcher https://apiview.dev/Assemblies/Review/692c3ca38a124cf599e624d760121724?revisionId=2cb4301ccc904e8da4534facdfaee13d
.Net Azure.ResourceManager.DevOpsInfrastructure https://apiview.dev/Assemblies/Review/29126cc9281244a6b6994267d158014e?revisionId=353dfbea6f0a4c8fbda4d54151c1dd28

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Feb 26, 2025
This was referenced Feb 26, 2025
@chrisradek chrisradek changed the title [Do not merge] Testing @extension changes Phase 1 @extension changes - add suppressions for upcoming deprecation warnings Feb 27, 2025
@chrisradek chrisradek marked this pull request as ready for review February 27, 2025 05:43
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 27, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

sdk/resourcemanager/databasefleetmanager/armdatabasefleetmanager
sdk/resourcemanager/databasewatcher/armdatabasewatcher
sdk/resourcemanager/deviceregistry/armdeviceregistry
sdk/resourcemanager/devopsinfrastructure/armdevopsinfrastructure
sdk/resourcemanager/iotoperations/armiotoperations
sdk/resourcemanager/mongocluster/armmongocluster
sdk/resourcemanager/recoveryservicesdatareplication/armrecoveryservicesdatareplication
sdk/resourcemanager/servicenetworking/armservicenetworking
sdk/resourcemanager/terraform/armterraform
sdk/resourcemanager/trustedsigning/armtrustedsigning
sdk/resourcemanager/workloadssapvirtualinstance/armworkloadssapvirtualinstance
sdk/resourcemanager/computefleet/armcomputefleet
Microsoft.AwsConnector
Microsoft.AgriculturePlatform
Microsoft.ApiCenter
Microsoft.AppComplianceAutomation
Microsoft.MachineLearningServices
Microsoft.AzureFleet
Microsoft.AzureLargeInstance
Microsoft.AzureStackHCI
Microsoft.Chaos
Microsoft.CodeSigning
Microsoft.ComputeSchedule
Microsoft.ContainerStorage
Microsoft.Portal
Microsoft.DatabaseFleetManager
Microsoft.DatabaseWatcher
Microsoft.DataReplication
Microsoft.DeviceRegistry
Microsoft.DocumentDB
Microsoft.PortalServices
Microsoft.ContainerService
Microsoft.Impact
Informatica.DataManagement
Microsoft.IoTOperations
Microsoft.IoTOperationsMQ
Microsoft.IoTOperationsOrchestrator
Microsoft.LoadTestService
Microsoft.AVS
Microsoft.AzureTerraform
Microsoft.DevOpsInfrastructure
Microsoft.Monitor
Microsoft.Quantum
Oracle.Database
Microsoft.Purview
Microsoft.ScVmm
Microsoft.SecretSyncController
Microsoft.ServiceNetworking
Microsoft.Sovereign
Microsoft.StandbyPool
Microsoft.Workloads

This was referenced Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants