Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] Add CustomCATrustCertificates in Managed Cluster's Security Profile to GA rest api spec #32863

Merged
merged 3 commits into from
Feb 27, 2025
Merged

[AKS] Add CustomCATrustCertificates in Managed Cluster's Security Profile to GA rest api spec #32863

merged 3 commits into from
Feb 27, 2025
+281 −0

Conversation

UtheMan
Copy link
Contributor

@UtheMan UtheMan commented Feb 26, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 26, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 26, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerservice/armcontainerservice There is no API change compared with the previous version
JavaScript @azure/arm-containerservice https://apiview.dev/Assemblies/Review/dabf043916d14dc38e0c2d456d89f55a?revisionId=a544024fea8345539df95292d6c48587
Python azure-mgmt-containerservice https://apiview.dev/Assemblies/Review/537688a5e5d147ffadfd453b0cfed0ee?revisionId=3b59f33cc5e74fce93a12a29e2e39abd

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 26, 2025
@azure-sdk azure-sdk mentioned this pull request Feb 26, 2025
Draft
This was referenced Feb 26, 2025
Draft
Draft
Draft
Draft
@azure-sdk azure-sdk mentioned this pull request Feb 26, 2025
Draft
FumingZhang
FumingZhang reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

seems there are some minor changes to the description, could you please apply them to the dev branch of preview API version too?
Screenshot 2025-02-27 095138

@FumingZhang
Copy link
Member

lgtm

seems there are some minor changes to the description, could you please apply them to the dev branch of preview API version too? Screenshot 2025-02-27 095138

PR for preview API #32876

@FumingZhang FumingZhang merged commit cea24e7 into Azure:dev-containerservice-Microsoft.ContainerService-2025-01-01 Feb 27, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FumingZhang FumingZhang FumingZhang left review comments

@palma21 palma21 Awaiting requested review from palma21 palma21 is a code owner

@matthchr matthchr Awaiting requested review from matthchr matthchr is a code owner

Assignees
No one assigned
Labels
brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Container Service resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UtheMan @FumingZhang @AzureRestAPISpecReview