-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release BillingBenefits microsoft.billingbenefits preview/2024-11-01-preview #32829
Release BillingBenefits microsoft.billingbenefits preview/2024-11-01-preview #32829
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2022-11-01 to preview/2024-11-01-preview.
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
a7ace6a
to
b1b07cc
Compare
Note that all of these changes have been approved by ARM already and are merged into RPSaaSMaster branch: |
@@ -26,11 +26,13 @@ These are the global settings for the billingbenefits. | |||
|
|||
```yaml | |||
openapi-type: arm | |||
tag: package-2022-11-01 | |||
openapi-subtype: providerHub | |||
tag: package-preview-2024-11-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tag definition doesn't exist in the readme.md
. Either change to another valid tag name or add the definition for the tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raych1: I feel like some check should catch this and print a clear error message. Do you know which check should handle this? Maybe Avocado? Or maybe the language emitters should also check this as defense-in-depth and show a clear error message?
Revert .npmrc Running prettier revert .npmrc Fixing tag defintion in readme revert spacing in readme.go.md fixing indentation error
1849eb4
to
b8e2798
Compare
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run ["Swagger SemanticValidation", "Swagger ModelValidation", "Swagger LintDiff", "Swagger Lint(RPaaS)", "Swagger BreakingChange", "SDK azure-sdk-for-go", "Breaking Change(Cross-Version)", "Automated merging requirements met"] |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for merge
…efits-preview/2024-11-01-preview
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.