Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating previously release api with missing properties within Microsoft.DBforPostgreSQL #32826

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Updating previously release api with missing properties within Microsoft.DBforPostgreSQL #32826

merged 1 commit into from
Feb 26, 2025
+5 −3

Conversation

nasc17
Copy link
Member

@nasc17 nasc17 commented Feb 25, 2025 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ X] Other, please clarify:
    • Updating existing versions for a missed option value in one of the properties. This aligns with the description of: The changes to the REST API definition are correcting the definition to accurately describe the service behavior.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • [X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ X] I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

Stable release 2024-08-01 and Preview release 2024-11-01 Added missing enum option for the property "UserAssignedIdentity"

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@nasc17 nasc17 added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Feb 25, 2025
@nasc17 nasc17 requested a review from a team as a code owner February 25, 2025 19:51
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 25, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 25, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/21a61d731117447dbd7223467d7cfa42?revisionId=5849d7f8f58e400e90a621f2639112b4
Python azure-mgmt-postgresqlflexibleservers https://apiview.dev/Assemblies/Review/2f26588813fb482db3523970145d3eb0?revisionId=a47fe9c776dd400f99203b07caec63d8

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 25, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.DBforPostgreSQL

This was referenced Feb 25, 2025
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 25, 2025
This was referenced Feb 25, 2025
Draft
Draft
Draft
Draft
nachoalonsoportillo
nachoalonsoportillo approved these changes Feb 26, 2025
View reviewed changes
Copy link

@nachoalonsoportillo nachoalonsoportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvanbadea-msft
Copy link
Contributor

Please fill out the Purpose of this PR and Due diligence checklist.

@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 26, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 26, 2025
@nasc17
Copy link
Member Author

nasc17 commented Feb 26, 2025

Please fill out the Purpose of this PR and Due diligence checklist.

Completed.

@nasc17
Copy link
Member Author

nasc17 commented Feb 26, 2025

For azure-sdk-for-net, similarly to last PR for updating a missed property, this can be ignored: #32330 (comment)

@nasc17 nasc17 merged commit d8fbf4f into Azure:main Feb 26, 2025
36 of 37 checks passed
naveedaz pushed a commit that referenced this pull request Feb 26, 2025
@azure-sdk @dependabot
@scbedd @msyyc @Yao725 @Jingshu918 @wanlwanl @albertxavier100 @Celinadhh @kazrael2119 @mccoyp @raych1 @ChenxiJiang333 @weidongxu-microsoft @adityareddy305 @tazlauanubianca @Y-Sindo @swells @Mayuri-Gadsing @JimSuplizio @micahbresette @nasc17 @mikeharder
Merge branch main into release-web-2024-11-01 (#32862)
afdef51 
* Bump @azure-tools/typespec-client-generator-core (#32797)

Bumps the typespec group with 1 update in the / directory: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure).


Updates `@azure-tools/typespec-client-generator-core` from 0.51.2 to 0.51.3
- [Release notes](https://github.com/Azure/typespec-azure/releases)
- [Commits](https://github.com/Azure/typespec-azure/compare/@azure-tools/[email protected]...@azure-tools/[email protected])

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Sync eng/common directory with azure-sdk-tools for PR 9902 (#32794)

* populate triggeringPaths of each artifactdetails with the owning ci.yml
* handle service-directory changes in Get-PrPkgProperties

---------

Co-authored-by: Scott Beddall <[email protected]>

* [keyvault] Update readme.python.md (#32530)

* update oracle linked service (#32750)

Co-authored-by: Jingshu918 <[email protected]>

* Add Go Data Plane Rules of tspconfig.yaml for TSV (#32779)

* manually add

* add go dp rules

* update

---------

Co-authored-by: albertxavier100 <[email protected]>

* Update Swagger for New PolicyDefinitions and PolicyTokens API (#32306)

* Copy files from stable/2025-01-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-03-01

Updated the API version from stable/2025-01-01 to stable/2025-03-01.

* Added tag for 2025-03-01 in readme file

* Update readme.md

* Add external evaluation enforcement settings contract

* Add policy token API contract

* Swagger PrettierCheck

* Swagger PrettierCheck

* Fix JsonSerializationException

* Update contract

* Swagger LintDiff

* Increment to v6

* Revert "Increment to v6"

This reverts commit 64631c5.

* Update error response

* Update duration

* Update sdk-suppressions.yaml

---------

Co-authored-by: Celina Zhao <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>

* [Key Vault] docs.microsoft.com -> learn.microsoft.com (#32769)

* Add Support for Changed Spec Identification in spec-gen-sdk-runner tool (#32763)

* Increase timeout for generation job

* Added git op to the wrapper tool

* cleaned all files before generation

* updated specGenCommand for multiple generation

* Used file system access for file search

* Combined tsp and readme for same service

* Update readme.python.md (#32838)

* Update tspconfig.yaml (#32839)

* migration accessment, config java sdk (#32840)

* Update tspconfig.yaml (#32823)

update name of sdk packaging

* Update MixedReality API with deprecation message (#32386)

* Update MixedReality API

* Copy existing API versino spec files

* Update new API

* Update README with new API version

* Add deprecation message for old API versions

---------

Co-authored-by: Bianca Tazlauanu <[email protected]>

* Add `ListConnectionsInGroup` Api (#31398)

* Copy files from stable/2024-01-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-12-01

Updated the API version from stable/2024-01-01 to stable/2024-12-01.

* Added tag for 2024-12-01 in readme file

* Update API spec and examples to 2024-12-01

* fix pagination according to https://github.com/Azure/azure-api-style-guide/blob/main/openapi-style-guide.md#support-for-pagination

* fix(azurearcdata): remove arm-id from sqlServerDatabases (#32825)

* fix(azurearcdata): remove arm-id from sqlServerDatabases

* SRP 2024-01-01 API Version Swagger - PV2 date-time properties fix (#32835)

* Code needs to handle more than one template library (#32853)

Co-authored-by: James Suplizio <[email protected]>

* Bump @autorest/openapi-to-typespec (#32834)

Bumps the openapi-to-typespec group with 1 update in the / directory: [@autorest/openapi-to-typespec](https://github.com/Azure/autorest).


Updates `@autorest/openapi-to-typespec` from 0.10.10 to 0.10.11
- [Release notes](https://github.com/Azure/autorest/releases)
- [Commits](https://github.com/Azure/autorest/commits)

---
updated-dependencies:
- dependency-name: "@autorest/openapi-to-typespec"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: openapi-to-typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Dev/mibreset/ccm exports fabric3 (#32444)

* Copy files from stable/2024-08-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-01-preview

Updated the API version from stable/2024-08-01 to preview/2024-10-01-preview.

* Added tag for 2024-10-01-preview in readme file

* ran prettier on entire directory

* made the changes for the fabric version

* fixed spelling issue in pricesheet.json

* adding 'destination type' as required since Destination is required and needs a required field

* Fixed messed up date/time format

* Fixed readme file, was missing the list of input files.

* Removed required annotation from exportDeliveryDestination.

* Include SystemAssigned,UserAssigned (#32826)

* [EngSys] npm update (#32857)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Yao Kou <[email protected]>
Co-authored-by: Jingshu918 <[email protected]>
Co-authored-by: Wanpeng Li <[email protected]>
Co-authored-by: albertxavier100 <[email protected]>
Co-authored-by: ccz77 <[email protected]>
Co-authored-by: Celina Zhao <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: McCoy Patiño <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Aditya <[email protected]>
Co-authored-by: Bianca Tazlauanu <[email protected]>
Co-authored-by: Bianca Tazlauanu <[email protected]>
Co-authored-by: yzt <[email protected]>
Co-authored-by: Sean Wells <[email protected]>
Co-authored-by: Mayuri-Gadsing <[email protected]>
Co-authored-by: James Suplizio <[email protected]>
Co-authored-by: Micah Bresette <[email protected]>
Co-authored-by: nasc17 <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
@wanlwanl
Copy link
Member

@welovej could you take a look https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4594447&view=logs&j=2be18a23-047c-5c9f-61d7-60a33437d1f1&t=90227b5e-3523-5803-3e16-3788cf693a16&l=366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachoalonsoportillo nachoalonsoportillo nachoalonsoportillo approved these changes

Assignees

@welovej welovej

@jianingwang123 jianingwang123

Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. PostgreSQL PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nasc17 @azure-sdk @razvanbadea-msft @wanlwanl @nachoalonsoportillo @welovej @AzureRestAPISpecReview @jianingwang123