Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.DataProtection] New ADLS backup parameter #32616

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

IannGeorges
Copy link
Member

Adding AdlsBlobBackupDatasourceParameters property for ADLS Blob Backup Parameters

@IannGeorges - This is a parameter addition on top of the stable version "2025-01-01" The added new "AdlsBlobBackupDatasourceParameters" property is similar to the existing BlobBackupDatasourceParameters, and will support the new ADLS blob backup workload.

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

ianna1-admin added 4 commits February 13, 2025 12:51
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-01-01 to stable/2025-02-01.
Copy link

openapi-pipeline-app bot commented Feb 13, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Feb 13, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/dataprotection/armdataprotection There is no API change compared with the previous version
JavaScript @azure/arm-dataprotection https://apiview.dev/Assemblies/Review/86d65b0627994d63a1e82847baff2216?revisionId=bc87360470ee4477a36a610774e7b6cb
Python azure-mgmt-dataprotection https://apiview.dev/Assemblies/Review/470e8ebb1ca041d0908bbf2559091e2e?revisionId=efb4d1286bc84cf7ba3f6fa66c779969
Java azure-resourcemanager-dataprotection https://apiview.dev/Assemblies/Review/b3e7b2d708da48ffb66f463064ff01d4?revisionId=9a817e81f47f4ce7b540f89ac0193b34

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 13, 2025
@IannGeorges
Copy link
Member Author

Hello @ramoka178,

Please review this new PR whenever you have a chance. As per team guidance I have created a new Swagger API version to include this new parameter object for ADLS Blob Backups.

This property, AdlsBlobBackupDatasourceParameters, is being used within the policyInfo.policyParameters objects to configure backups for the Azure Data Lake Storage workload, this parameter is similar to the existing BlobBackupDatasourceParameters within the dataprotection.json

I have included two examples to demonstrate the use of this new parameter.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.DataProtection

@ramoka178
Copy link
Contributor

"AdlsBlobBackupDatasourceParameters": {

where in the swagger is this being used ?


Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2025-02-01/dataprotection.json:5157 in bdac2d4. [](commit_id = bdac2d4, deletion_comment = False)

@ramoka178
Copy link
Contributor

"AdlsBlobBackupDatasourceParameters": {

Also, up to the team, but I think you can append new properties in the same api-version without any breaking change , without creating a new api-version.


In reply to: 2657894532


Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2025-02-01/dataprotection.json:5157 in bdac2d4. [](commit_id = bdac2d4, deletion_comment = False)

@ramoka178
Copy link
Contributor

Please fix Swagger Avocado and Swagger PrettierCheck failures

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 13, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 13, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Feb 19, 2025
@IannGeorges
Copy link
Member Author

Hey @ramoka178 could you please review the current PR? I have followed up in the Azure SDK channel regarding the failure due to Parameters in the object name.

@ramoka178 ramoka178 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Feb 21, 2025
@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 21, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 21, 2025
@IannGeorges IannGeorges added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants