Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding client affinity proxy settings #32557

Open
wants to merge 3 commits into
base: release-web-2024-11-01
Choose a base branch
from

Conversation

madsd
Copy link

@madsd madsd commented Feb 11, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@madsd madsd requested a review from naveedaz as a code owner February 11, 2025 09:25
Copy link

openapi-pipeline-app bot commented Feb 11, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Feb 11, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice Create ApiView timeout. Package is too large and we cannot create ApiView for it.
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=35ee649b7f9343798358fd17eb0107fd

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 11, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 11, 2025
@madsd
Copy link
Author

madsd commented Feb 12, 2025

Thank you @ramoka178 for the review. I added examples and commented on the boolean design.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChange-Go-Sdk brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager Web Apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants