Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OutboundVnetRouting site property to 2024-11-01 Api Version #32022

Open
wants to merge 6 commits into
base: release-web-2024-11-01
Choose a base branch
from
Open

Add OutboundVnetRouting site property to 2024-11-01 Api Version #32022

wants to merge 6 commits into from

Conversation

xingyangli1278
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 7, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 7, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice Create ApiView timeout. Package is too large and we cannot create ApiView for it.
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/98dbdc8147d7472b9bdff567a8b291bc?revisionId=376ea29c3ed24769a3a8fc6af320f944

This was referenced Jan 7, 2025
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 7, 2025
@azure-sdk azure-sdk mentioned this pull request Jan 7, 2025
Draft
@azure-sdk azure-sdk mentioned this pull request Jan 7, 2025
Draft
@xingyangli1278
Copy link
Contributor Author

Description:

For Api-Versions 2014-11-01 and later, OutboundVnetRouting will be the only site property controlling outbound traffic over virtual network for sites, replacing individual site properties (VnetRouteAllEnabled, VnetBackupRestoreEnabled, etc.).

This change adds the OutboundVnetRouting object and removes the individual vnet routing flags from the site properties definitions.

@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 9, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 9, 2025
@tadelesh tadelesh added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jan 10, 2025
@tadelesh
Copy link
Member

@raych1 could you help to check why this pr has not labeled with Breaking ChangeReviewRequired automatically?

@raych1
Copy link
Member

raych1 commented Jan 13, 2025

@tadelesh Breaking Change(Cross-Version) check should add the BreakingChangeReviewRequired label based on its result. It seems a bug of this check. Could you create an issue in this spec repo then assign to @mikeharder ?

@tadelesh tadelesh mentioned this pull request Jan 13, 2025
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Feb 3, 2025
@xingyangli1278 xingyangli1278 removed the no-recent-activity There has been no recent activity on this issue. label Feb 11, 2025
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 27, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 27, 2025
This was referenced Feb 27, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveedaz naveedaz Awaiting requested review from naveedaz naveedaz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager Web Apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xingyangli1278 @tadelesh @raych1 @azure-sdk @AzureRestAPISpecReview @razvanbadea-msft @xingyang-li @naveedaz