Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleet autoupgrade GA - add autoupgradeprofilestatus #32634

Open
wants to merge 7 commits into
base: release-aks-fleet-2025-03-01
Choose a base branch
from
Open

fleet autoupgrade GA - add autoupgradeprofilestatus #32634

wants to merge 7 commits into from
+396 −142

Conversation

frantran
Copy link
Member

@frantran frantran commented Feb 14, 2025 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Adding some new properties into release branch for new API version 2025-03-01

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 14, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 14, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet https://apiview.dev/Assemblies/Review/f64970e51f984f5bb4be15a37b7c5ab3?revisionId=bafacdb816834d1a82fa3bba6a8814f5
JavaScript @azure/arm-containerservicefleet https://apiview.dev/Assemblies/Review/65c668ceaa2346708bf1e479b7f6b79b?revisionId=39feaceb98aa418b8ffeb60ab51ad2a9
Python azure-mgmt-containerservicefleet https://apiview.dev/Assemblies/Review/e0444ab348814233b7add2d104e5bcaa?revisionId=65750def57834222b4be09b81b138ede
Java azure-resourcemanager-containerservicefleet https://apiview.dev/Assemblies/Review/8422e73bfd5d45efb77d0cf066bec1a0?revisionId=a7ea0f8b7c1f45dea23cc92fdced27a2

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 14, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ContainerService

@frantran frantran changed the base branch from main to release-aks-fleet-2025-03-01 February 14, 2025 02:43
@azure-sdk azure-sdk mentioned this pull request Feb 14, 2025
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-RpaaSRPNotInPrivateRepo data-plane new-api-version NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec labels Feb 14, 2025
This was referenced Feb 14, 2025
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed RPaaS new-api-version NotReadyForARMReview CI-RpaaSRPNotInPrivateRepo data-plane ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Feb 14, 2025
This was referenced Feb 14, 2025
Draft
Draft
Draft
ramoka178
ramoka178 reviewed Feb 14, 2025
View reviewed changes
...ainerservice/resource-manager/Microsoft.ContainerService/fleet/stable/2025-03-01/fleets.json
@@ -2249,6 +2278,36 @@
},
"readOnly": true
},
"AutoUpgradeProfileStatus": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoUpgradeProfileStatus

update examples to show this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ramoka178
ramoka178 reviewed Feb 14, 2025
View reviewed changes
...ainerservice/resource-manager/Microsoft.ContainerService/fleet/stable/2025-03-01/fleets.json
"type": "object",
"description": "AutoUpgradeProfileStatus is the status of an auto upgrade profile.",
"properties": {
"lastTriggeredAt": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastTriggeredAt

lastTriggeredAtInUTC ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the preference would be to keep the naming as is, as style of existing fleet datatypes with time do not include "InUTC"

example: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerservice/Fleet.Management/update/run.tsp#L181

ramoka178
ramoka178 reviewed Feb 14, 2025
View reviewed changes
...ainerservice/resource-manager/Microsoft.ContainerService/fleet/stable/2025-03-01/fleets.json Outdated
"readOnly": true
},
"lastTriggerError": {
"$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorDetail",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3

v5 or v6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ramoka178
ramoka178 reviewed Feb 14, 2025
View reviewed changes
...ainerservice/resource-manager/Microsoft.ContainerService/fleet/stable/2025-03-01/fleets.json
"description": "The error details of the last trigger.",
"readOnly": true
},
"lastTriggerUpgradeVersions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastTriggerUpgradeVersions

can these come from enums ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there will be a large amount / undefined variations of version types

ramoka178
ramoka178 reviewed Feb 14, 2025
View reviewed changes
...ainerservice/resource-manager/Microsoft.ContainerService/fleet/stable/2025-03-01/fleets.json
@@ -2212,6 +2237,10 @@
"disabled": {
"type": "boolean",
"description": "If set to False: the auto upgrade has effect - target managed clusters will be upgraded on schedule.\nIf set to True: the auto upgrade has no effect - no upgrade will be run on the target managed clusters.\nThis is a boolean and not an enum because enabled/disabled are all available states of the auto upgrade profile.\nBy default, this is set to False."
},
"autoUpgradeProfileStatus": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoUpgradeProfileStatus

update examples to show this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ramoka178
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Please fill in this too.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 14, 2025
@frantran frantran force-pushed the ftran/fleet/autupgradeprofilestatus branch from d0e054a to 0541cf1 Compare February 25, 2025 06:35
@frantran frantran removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 25, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 25, 2025
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 26, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 26, 2025
@frantran frantran force-pushed the ftran/fleet/autupgradeprofilestatus branch from df281e4 to 988b0d3 Compare February 27, 2025 01:55
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

1 similar comment
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

add autoupgradeprofilestatus
b43b9ed 
add tsp files

add v5 version

generate examples

transfer examples

try generate oav

fix generate

transfer examples

fix  gen

fix format

run prettier on examples

manual fix examples

copy examples

fix updateid

fix subid

fix lro header

copy

run pretty

add sub param

copy

add sub param

add sub

reset examples

reset to release

reset examples
@frantran frantran force-pushed the ftran/fleet/autupgradeprofilestatus branch from 193565b to b43b9ed Compare February 27, 2025 02:46
@frantran frantran force-pushed the ftran/fleet/autupgradeprofilestatus branch from 237e908 to 3bdbac9 Compare February 27, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhng22 minhng22 minhng22 left review comments

@ramoka178 ramoka178 ramoka178 left review comments

@palma21 palma21 Awaiting requested review from palma21 palma21 is a code owner

@matthchr matthchr Awaiting requested review from matthchr matthchr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Container Service PipelineBotTrigger resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frantran @azure-sdk @ramoka178 @minhng22 @AzureRestAPISpecReview @razvanbadea-msft