From c4f1529d1ec024987089f4157e0764d606f3d2a2 Mon Sep 17 00:00:00 2001
From: Beisi Zhou <bez@microsoft.com>
Date: Tue, 18 Jun 2024 15:38:25 +0800
Subject: [PATCH] Change ConfigMetrics from Array to Dictionary (#422)

* Change ConfigMetrics from array to dictionary

* add telemetry key for config
---
 .../Models/ConfigMetrics.cs                        | 14 +++++++++++---
 src/Common/MetricHelper.cs                         |  6 +++---
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/Authentication.Abstractions/Models/ConfigMetrics.cs b/src/Authentication.Abstractions/Models/ConfigMetrics.cs
index 9d7c594c62..4147e64cc1 100644
--- a/src/Authentication.Abstractions/Models/ConfigMetrics.cs
+++ b/src/Authentication.Abstractions/Models/ConfigMetrics.cs
@@ -28,6 +28,11 @@ public class ConfigMetrics: IExtensibleModel
         /// </summary>
         public string ConfigKey { get; private set; }
 
+        /// <summary>
+        /// The unique telemetry key of config. It's required for recording config telemetry. If not provided, it's same with ConfigKey.
+        /// </summary>
+        public string TelemetryKey { get; private set; }
+
         /// <summary>
         /// Config value in string format. It's required for recording config telemetry.
         /// </summary>
@@ -35,10 +40,13 @@ public class ConfigMetrics: IExtensibleModel
 
         public IDictionary<string, string> ExtendedProperties { get; } = new ConcurrentDictionary<string, string>(StringComparer.OrdinalIgnoreCase);
 
-        public ConfigMetrics(string ConfigKey, string ConfigValue)
+        public ConfigMetrics(string configKey, string configValue): this(configKey, configKey, configValue){}
+
+        public ConfigMetrics(string configKey, string telemetryKey, string configValue)
         {
-            this.ConfigKey = ConfigKey;
-            this.ConfigValue = ConfigValue;
+            this.ConfigKey = configKey;
+            this.TelemetryKey = telemetryKey;
+            this.ConfigValue = configValue;
         }
     }
 }
diff --git a/src/Common/MetricHelper.cs b/src/Common/MetricHelper.cs
index 737f5ac23e..5b85c5043d 100644
--- a/src/Common/MetricHelper.cs
+++ b/src/Common/MetricHelper.cs
@@ -508,7 +508,7 @@ private void PopulateConfigMetricsFromQos(AzurePSQoSEvent qos, IDictionary<strin
             {
                 foreach (var configMetric in qos.ConfigMetrics)
                 {
-                    eventProperties[configMetric.ConfigKey] = configMetric.ConfigValue;
+                    eventProperties[configMetric.Value.TelemetryKey] = configMetric.Value.ConfigValue;
                 }
             }
         }
@@ -670,7 +670,7 @@ public class AzurePSQoSEvent
     public string ParameterSetName { get; set; }
     public string InvocationName { get; set; }
 
-    public List<ConfigMetrics> ConfigMetrics { get; private set; } 
+    public Dictionary<string, ConfigMetrics> ConfigMetrics { get; private set; } 
 
     public Dictionary<string, string> CustomProperties { get; private set; }
 
@@ -683,7 +683,7 @@ public AzurePSQoSEvent()
         StartTime = DateTimeOffset.Now;
         _timer = new Stopwatch();
         _timer.Start();
-        ConfigMetrics = new List<ConfigMetrics>();
+        ConfigMetrics = new Dictionary<string, ConfigMetrics>();
         CustomProperties = new Dictionary<string, string>();
     }