-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of strange errors when migrating existing "Live Archive" assets #251
Comments
let me add some initial comments first to explain the issues.
unfortunately, in both of these case, we're not sure if there are easy/good solutions right now... |
I've looked into the source code (TransMuxer.cs, line 254). For me it looks like the exception occurs when the migrator tries to fix issues with the stream length, which requires sampleDuration for calculation. I think that the exception is not neccessary here, a warning that the stream cannot be checked is enough - and of course only do the checks when possible? |
hi @schuettecarsten, @duggaraju gave a great suggestion on issue 1. First one looks like a bug in our code? Are we assuming that a 'trun' box is always present even if all samples have same duration and the duration is specified in the tfhd box? so maybe this can be fixed easily... i'm wondering if you can provide sample for issue 1 to check this? |
Sure, but I cannot post this here - please drop me an email |
Also, if you are interested, I put up a draft PR to address the ‘Unexpected, sampleDurationPresent must be present‘ issue but I couldn’t test it out. |
@pohhsu @duggaraju The issue with the missing sampleDurationPresent is fixed with the draft PR and the resulting asset looks good. For the missing chunks issue, a lot of our assets are affected by this and we need to migrate them. So, maybe it's an option to simply ignore the gaps, add black there or repeat the previous chunk? |
We have a bunch of "Live Archive" assets that we need to migrate before AMS is retired. They were all recorded by AMS using RTMP ingest during the last few years and can be played without any known issues. But migration fails with different errors on most of these assets.
For example:
Some of them are complaining about gaps and missing chunks, log does not show on which asset which makes it difficult to figure out if this error will cause whe whole asset to fail:
Any ideas how to mitigate these errors?
Let me know if you need sample assets.
The text was updated successfully, but these errors were encountered: