From 00c23606cc8afb699ee17790c51a85c0abf6d296 Mon Sep 17 00:00:00 2001 From: Erik O'Leary <969938+onionhammer@users.noreply.github.com> Date: Mon, 7 Jan 2019 10:31:35 -0600 Subject: [PATCH] Fix ParseMachineId (#459) Fix issue parsing manual machine id; fixes #458 - second parameter of `Substring` is 'length' not 'index' --- src/DotNetty.Transport/Channels/DefaultChannelId.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DotNetty.Transport/Channels/DefaultChannelId.cs b/src/DotNetty.Transport/Channels/DefaultChannelId.cs index 1ea5edab5..05a7e3d92 100644 --- a/src/DotNetty.Transport/Channels/DefaultChannelId.cs +++ b/src/DotNetty.Transport/Channels/DefaultChannelId.cs @@ -123,7 +123,7 @@ static byte[] ParseMachineId(string value) var machineId = new byte[MachineIdLen]; for (int i = 0; i < value.Length; i += 2) { - machineId[i] = (byte)int.Parse(value.Substring(i, i + 2), NumberStyles.AllowHexSpecifier); + machineId[i] = (byte)int.Parse(value.Substring(i, 2), NumberStyles.AllowHexSpecifier); } return machineId; } @@ -251,4 +251,4 @@ public override bool Equals(object obj) public override string ToString() => this.AsShortText(); } -} \ No newline at end of file +}