Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images on the tiles #624

Closed
khowling opened this issue Jul 28, 2023 · 8 comments
Closed

Fix images on the tiles #624

khowling opened this issue Jul 28, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper stale An issue that hasn't had a lot of love recently

Comments

@khowling
Copy link
Contributor

khowling commented Jul 28, 2023

Images no longer appear on the tiles in the UI helper.

The Tile format support 2 types of graphic, either a Icon or a Image, the Icon works OK, but the Images no longer show. For example, see the helper/src/configpresents/entScale.json, you can see the imageSrc key.

To Reproduce
In the UI Helper, select any option except for 'principle driven', and the images are not appearing on the tiles.

@khowling khowling added good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper labels Jul 28, 2023
@gcontreras3
Copy link

Hello @khowling I can fix this issue, assign it over :)

@Gordonby
Copy link
Collaborator

duplicate of #602 ?

@AdityaAgarwaal
Copy link

Hello @khowling I would like to contribute to this issue, kindly assign it to me. Thanks

@AdityaAgarwaal
Copy link

@khowling Please assign this issue to me, I would love to contribute on it. Thanks :)

@AdityaAgarwaal
Copy link

@khowling Your review on my current PR will be much appreciated. Thank you

@AdityaAgarwaal
Copy link

@khowling Please review my PR. Thankyou

@AdityaAgarwaal
Copy link

@khowling I have made the changes that you mentioned in my latest commit, Please review it. Thankyou.

@github-actions
Copy link
Contributor

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper stale An issue that hasn't had a lot of love recently
Projects
None yet
Development

No branches or pull requests

4 participants