update to support transfer #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onClick={async () => this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOff())}> | ||
| onClick={async () => { | ||
| this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOff()); | ||
| this.props.onReject(); |
There was a problem hiding this comment.
why are we calling onReject here?
There was a problem hiding this comment.
I took this part from another PR that had some initial scaffolding, I'm not sure why. It seems to work as intended. Will ask original author
vriosrada-msft
approved these changes
Dec 16, 2024
pkestikar
reviewed
Dec 17, 2024
| @@ -67,11 +68,11 @@ export default class CallCard extends React.Component { | |||
| canSpotlight: this.capabilities.spotlightParticipant?.isPresent || this.capabilities.spotlightParticipant?.reason === 'FeatureNotSupported', | |||
| canMuteOthers: this.capabilities.muteOthers?.isPresent || this.capabilities.muteOthers?.reason === 'FeatureNotSupported', | |||
| canReact: this.capabilities.useReactions?.isPresent || this.capabilities.useReactions?.reason === 'FeatureNotSupported', | |||
| videoOn: this.call.isLocalVideoStarted, | |||
There was a problem hiding this comment.
Nit: why remove the usage of isLocalVideoStarted? I'd suggest to keep this in as this is a sample and isLocalVideoStarted is a GA API on the SDK.
pkestikar
reviewed
Dec 17, 2024
| screenSharingOn: this.call.isScreenSharingOn, | ||
| micMuted: this.call.isMuted, | ||
| videoOn: !!props.call.localVideoStreams[0], | ||
| screenSharingOn: props.callIsScreenShareOn, |
There was a problem hiding this comment.
props.call.isScreenSharingOn?
| return; | ||
| } | ||
| try { | ||
| var id = {communicationUserId: this.destinationUserId.value} |
There was a problem hiding this comment.
Suggested change
| var id = {communicationUserId: this.destinationUserId.value} | |
| const id = {communicationUserId: this.destinationUserId.value} |
fizampou
reviewed
Dec 17, 2024
| onClick={async () => this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOff())}> | ||
| onClick={async () => { | ||
| this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOff()); | ||
| this.props.onReject(); |
There was a problem hiding this comment.
I think the reject here is a hack, we shall fix it properly by cleaning up old call/state and adding the new one
fizampou
reviewed
Dec 17, 2024
| onClick={async () => this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOn())}> | ||
| onClick={async () => { | ||
| this.incomingCall.accept(await this.acceptCallMicrophoneUnmutedVideoOn()); | ||
| this.props.onReject(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
I manually tested stuff within calls (video, video effects, call holding, resuming, spotlight, raise hand within transfer flows (before and after transfer). Probably did not test every scenario
Other Information