Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of stocks in the stock screener is misleading #46

Open
sancho21 opened this issue Jul 14, 2022 · 1 comment
Open

Number of stocks in the stock screener is misleading #46

sancho21 opened this issue Jul 14, 2022 · 1 comment

Comments

@sancho21
Copy link
Contributor

The number of stocks should be updated to reflect the number of shariah compliant only, if the toggle is on

image

@AzrizHaziq
Copy link
Owner

This require more JS logic to work with:

  • when no search, need to recalculate the total no of shariah with selected current market
  • when there is search, need to recalculate again with the no of item available in the list
  • most important things is TV is using virtual list to render all the item, so can be more tricky to calcuate.
  • Also i'm using if else in CSS rather than if else in JS to hide/display. Some user report with prev approach can slow down their performance. See this commit
  • Also need to consider again if user select multiple country image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants