Proposal: Remove Default/Simple Theme

[robloo]

I'm a little biased as I sit here and write a default theme for a new control. However, I wonder why is this default theme still supported? Default is:

• Inferior to Fluent v1 in terms of quality
• Far inferior to Fluent v1 in terms of design fidelity and user experience
• An unnecessary maintenance burden
• Has clear errors (Foreground Brush doesn't change when checked):
  

About the only thing going for it is it's lightweight and what is used in legacy apps. However, Fluent v1 has been around for a few years now. It might be time to cut off the dead weight. Then Fluent v2 can be added in addition to -- or in replacement of -- Fluent v1.

Apps that need the old theme can either:

• Keep using old versions of Avalonia
• Copy the themes into their own project

I see Default theme as a lot of dead weight and wonder when is a good time to cut it loose.

[maxkatz6]

In next major release it will be moved out of main package and distributed as separated nuget package (same for Fluent).
We are not planning to completely remove it anytime soon. Although with stable API it could be used from nuget package even being out-of-dated.

[grokys]

Default/simple theme is still used in unit tests and by some of our customers running on low power devices, so it won't be removed. As @maxkatz6 says, it will be moved to a separate package for 11.0 though.

[robloo]

I'm surprised there are customers using this in production:

.

Contrast and usability requirements are usually mandatory before shipping. I have to think they modified the style or never use a toggle button then. If they modified the style they certainly can pull the default styles into their own app.

Anyway, I understand if you have paying customers it is prudent to maintain perfect compatibility; I'm just surprised. Unit tests are a problem too.

I just hope you have have an idea how to sunset this in the future.

[maxkatz6]

Default one can be used as a base theme, on top of which they build their own themes.
And yes, there are still applications that use default without any major changes as well. Been there.