Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode: Stuck on "Getting code actions from 'Harper'" #486

Open
mcecode opened this issue Jan 24, 2025 · 3 comments · May be fixed by #496
Open

VSCode: Stuck on "Getting code actions from 'Harper'" #486

mcecode opened this issue Jan 24, 2025 · 3 comments · May be fixed by #496
Labels
bug Something isn't working

Comments

@mcecode
Copy link
Collaborator

mcecode commented Jan 24, 2025

This was mentioned in #441. Filing as an issue so we can track it.

The issue seems to be intermittent and is hard to replicate, so I tried a bunch of things and could finally replicate it using the following steps:

  1. Open VSCode with the Harper extension disabled.
  2. Open a file that harper-ls can lint like a Markdown file.
  3. Enable the Harper extension.
  4. Type anything in the file you opened and try to save it with ctrl+s.
  5. Saving the file gets blocked indefinitely until you click "Skip" on the pop-up that shows up:
    Image

Some notes:

  • The extension does not work (you get no diagnostics) even after you click on "Skip".
  • Step 2 is important, the issue does not occur if you enable the extension while no files that harper-ls can lint is open.
  • The harper-ls process that was spawned by the extension when it is activated in step 3 does not get terminated even after the extension is deactivated. The process instead, at least for my system, gets attached to systemd instead of VSCode.
  • I'm not sure why this is happening or if this is the only way to replicate this issue.
@hippietrail
Copy link
Contributor

There is at least a small chance this is related to #466 where I intermittently have runaway harper-ls processes than pin one or more cores.

Is harper-ls consuming CPU when this happens?

@mcecode
Copy link
Collaborator Author

mcecode commented Jan 24, 2025

Is harper-ls consuming CPU when this happens?

From what I can tell, at least for my system, no. The runaway harper-ls processes when this happens seems to be idle.

@elijah-potter
Copy link
Collaborator

I haven't been able to replicate this on my system. That said, this stinks of a deadlock when Visual Studio Code requests diagnostics at the time as it configures Harper.

@elijah-potter elijah-potter linked a pull request Jan 24, 2025 that will close this issue
@elijah-potter elijah-potter added the bug Something isn't working label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants