Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is .widget-area outside of .site-content? #1307

Closed
olegovk opened this issue Jul 31, 2018 · 2 comments
Closed

Why is .widget-area outside of .site-content? #1307

olegovk opened this issue Jul 31, 2018 · 2 comments

Comments

@olegovk
Copy link

olegovk commented Jul 31, 2018

It seems from previous discussions that .widget-area used to be a sibling of .content-area, i.e. inside of .site-content. According to naming convention it looks very logical this way. However now .widget-area is outside of .site-content.

Is there a specific reason why it's outside now, making it a site-level element, rather than part of site content?

@GitaStreet
Copy link

Where do you see this?
I see the starting .site-content starts in header.php and closing in footer.php.

index.php and page.php use to get_sidebar() before get_footer() - so .widget-area is still wrapped in the .site-content.

@olegovk
Copy link
Author

olegovk commented Aug 1, 2018

How embarrassing... you are right.
Thanks for kindly answering, though.

@olegovk olegovk closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants