Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DLSP22] typo in 16-gated_GCN.ipynb #820

Closed
lcqsigi opened this issue Apr 21, 2022 · 3 comments
Closed

[DLSP22] typo in 16-gated_GCN.ipynb #820

lcqsigi opened this issue Apr 21, 2022 · 3 comments

Comments

@lcqsigi
Copy link
Contributor

lcqsigi commented Apr 21, 2022

batch_x_e

batch_scores = model(batch_graphs, batch_X, batch_E, batch_snorm_n, batch_snorm_e)
print(batch_scores.size())

batch_labels = batch_labels
print(f'accuracy: {accuracy(batch_scores, batch_labels)}')

torch.Size([10, 8])
accuracy: 10

@lcqsigi lcqsigi changed the title 16-gated_GCN.ipynb in cell # 15, it should be batch_X and batch_E [DLSP22]16-gated_GCN.ipynb in cell # 15, it should be batch_X and batch_E Apr 25, 2022
@Atcold
Copy link
Owner

Atcold commented Apr 25, 2022

Can you describe the issue?

@lcqsigi
Copy link
Contributor Author

lcqsigi commented Apr 25, 2022

Upon running this notebook (i.e., 16-gated_GCN.ipynb) with python version 3.9.7, torch version 1.10.2, jupyter-notebook version 6.4.5, and dgl version 0.6.0, cell # 15 of the notebook prints: NameError: name 'batch_x' is not defined. If one replaces, the batch_scores definition with batch_X and batch_E in cell # 15 of the original 16-gated_GCN.ipynb notebook, the notebook runs to completion reporting a test_acc: 0.9900 after 40 Epochs.

@Atcold
Copy link
Owner

Atcold commented Apr 26, 2022

Oh, oh, I see, it's just a typo you fixed in #821.
Cool, thanks.

@Atcold Atcold closed this as completed Apr 26, 2022
@Atcold Atcold changed the title [DLSP22]16-gated_GCN.ipynb in cell # 15, it should be batch_X and batch_E [DLSP22] typo in 16-gated_GCN.ipynb Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants