Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disconnect a connected CP client JSON Node After Deploy #50

Open
abkulakli opened this issue May 22, 2023 · 5 comments
Open

Cannot disconnect a connected CP client JSON Node After Deploy #50

abkulakli opened this issue May 22, 2023 · 5 comments
Assignees
Labels
Waiting Feedback awaiting further feedback or testing

Comments

@abkulakli
Copy link
Contributor

abkulakli commented May 22, 2023

To Reproduce:

  1. Connect a CP Client JSON node with
{
    "msgType": 99,
    "command": "connect",
    "data": { }
}
  1. Deploy changes
  2. Disconnect the CP Client JSON node with (Because it seems still connected)
{
    "msgType": 99,
    "command": "close",
    "data": ""
}

Result: Client still connected
Expected Result: Client Disconnected

@abkulakli abkulakli changed the title CP client JSON Node Lost Connection After Deploy Cannot Disconnected a connected CP client JSON Node After Deploy May 22, 2023
@abkulakli abkulakli changed the title Cannot Disconnected a connected CP client JSON Node After Deploy Cannot disconnect a connected CP client JSON Node After Deploy May 22, 2023
@bnystrom
Copy link
Collaborator

Try v1.3.5 and see if you still encounter this.

@bnystrom bnystrom self-assigned this May 22, 2023
@abkulakli
Copy link
Contributor Author

Same results with 1.3.5

@abkulakli
Copy link
Contributor Author

If you send connect message again while it seems connected, then you can disconnect

@daviddhauwe
Copy link
Contributor

I also had connection problems with my CPO after deploying. In may case fequent connect/disconnect. I just created a pull request which solves my issue.

@bnystrom bnystrom added the Waiting Feedback awaiting further feedback or testing label Jul 19, 2023
@bnystrom
Copy link
Collaborator

@abkulakli I merged @daviddhauwe fix into v1.3.6. Please try with that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting Feedback awaiting further feedback or testing
Projects
None yet
Development

No branches or pull requests

3 participants