Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nickname() and email() dont work. #10

Open
pbiggar opened this issue Jan 13, 2010 · 7 comments
Open

nickname() and email() dont work. #10

pbiggar opened this issue Jan 13, 2010 · 7 comments

Comments

@pbiggar
Copy link

pbiggar commented Jan 13, 2010

When I log in using a google account, nickname() and email() are both None. Looking at the dashboard, both nickname and email are None, but server_url is filled in. I checked that those fields were enabled in my profile, and they were.

The endpoint is https://www.google.com/accounts/o8/id.

@modkit
Copy link

modkit commented Jan 15, 2010

Yes. I also have the same issue..
I entered the following endpoint into the openid url box:

https://www.google.com/accounts/o8/id

I am then redirected to a google accounts login page, but am not told that I am sharing my email and nickname as is expected..

For example, when logging into demand.openid.net through openid and my google account, I get the following before login:

Demand-openid.rpxnow.com is asking for some information from your Google Account. To see and approve the request, sign in. Learn more

and the following after logging in:

Demand-openid.rpxnow.com is asking for some information from your Google Account [email protected]
• Email address: nickname ([email protected])
• Language: English

But when coming from your demo app, I get the following before signing in:

Sign in to Myplaysandbox.appspot.com with your Google Account. Learn more

And the following after:

You are signing in to Myplaysandbox.appspot.com with your Google Account [email protected]

Can you verify that the nickname and email features are working with other providers and which ones.. The demo app is up at: http://myplaysandbox.appspot.com. Are you able to login and see your nickname in the demo? I'm motivated to track down this problem, but would like to verify what state the aeoid lib is in and if this is a google specific problem or not..

@Arachnid
Copy link
Owner

I know they work with myvidoop. It's using the sreg extension, so I don't know why it wouldn't work. I'll look into it.

@modkit
Copy link

modkit commented Jan 15, 2010

At quick glance it doesn't seem google is using the sreg extension so we may need to use the attribute exchange (AX) extension:

http://code.google.com/apis/accounts/docs/OpenID.html#Parameters

@yesudeep
Copy link

Facing the same issue.

@modkit
Copy link

modkit commented Jan 29, 2010

@yesudeep.. The problem is as explained.. You need to use AX not SREG.. I have a version in progress.. You can try it at http://myplaysandbox.appspot.com

Haven't gotten around to polishing and submitting but you can send me a private message if you want the source..

@Arachnid
Copy link
Owner

@modkit People are clamouring for the patch. No pressure. ;)

@EvanK
Copy link
Contributor

EvanK commented Feb 17, 2010

Even if we use AX, we still have to know what to ask for.

  • Yahoo makes available a "nickname" attribute
  • Google has no "nickname" attribute, but makes available a "firstname" and "lastname", so we can combine the two to make a nickname

What if we have a hypothetical provider that makes available an email but nothing even closely resembling a nickname? Should we fill it in with the email, as App Engine's own User class does?

And then of course, we have providers out there that support neither SREG nor AX, like MySpace. In this case, nickname and email will be empty regardless, so they're just a lost cause.

So it seems to me that the best solution would be to use both SREG and AX, then use whichever the provider returns. If they return both (don't know if that's even possible), just favor the simplest one (SREG?)

ADDENDUM: We also have providers who support one or the other (or both), but don't advertise it in their XRDS, like AOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants