Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Tags: Work correctly on non-NPF posts #965

Closed
marcustyphoon opened this issue Feb 11, 2023 · 1 comment · Fixed by #969
Closed

Quick Tags: Work correctly on non-NPF posts #965

marcustyphoon opened this issue Feb 11, 2023 · 1 comment · Fixed by #969
Assignees
@marcustyphoon
Labels
enhancement New feature or request

Comments

@marcustyphoon
Copy link
Collaborator

Concept

Right now, non-text-only legacy posts can't be tagged using Quick Tags.

This should be fixable by implementing an alternative API call using the mass post editor endpoint if the post has isBlocksPostFormat: false. (This isn't technically ideal, I believe; text-only legacy posts will have this flag but can be edited using the regular NPF edit endpoints. But both endpoints should do the same thing as far as I know, right? So it shouldn't matter.)
@marcustyphoon marcustyphoon added enhancement New feature or request help wanted Extra attention is needed labels Feb 11, 2023
@AprilSylph AprilSylph mentioned this issue Feb 12, 2023
Closed
@marcustyphoon
Copy link
Collaborator Author

This isn't technically ideal, I believe; text-only legacy posts will have this flag but can be edited using the regular NPF edit endpoints.

further discussion in xkit 7 discord: https://discord.com/channels/104051306309644288/327155782934200320/1074286553733533738

@marcustyphoon marcustyphoon self-assigned this Feb 13, 2023
@marcustyphoon marcustyphoon removed the help wanted Extra attention is needed label Feb 13, 2023
@AprilSylph AprilSylph linked a pull request Mar 13, 2023 that will close this issue
Quick Tags: Work correctly on non-NPF posts #969
Merged
@AprilSylph AprilSylph mentioned this issue Mar 13, 2023
Closed
@marcustyphoon marcustyphoon mentioned this issue May 9, 2023
Merged
@marcustyphoon marcustyphoon mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcustyphoon marcustyphoon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quick Tags: Work correctly on non-NPF posts marcustyphoon/XKit-Rewritten
1 participant
@marcustyphoon