Quick Tags (and Trim Reblogs and Quick Flags PR): tipping status lost

[marcustyphoon]

Platform

MacOS 10.15.7 x86

Browser

Ungoogled Chromium v107.0.5304.110

Addon version

v0.21.0

Details

Adding a tag to an original post with Quick Tags turns off tipping on the post; we don't pass through canBeTipped and I guess undefined is falsey.

This presumably technically isn't an issue in Trim Reblogs, since you can't have tipping on a non-original post and you can only run Trim Reblogs on those, but more generally, an audit of passthrough fields that may be missing from our post-editing code seems wise.

For editing a post, all of the request parameters from the NPF Post Creation route are expected (depending on if it's an original post or reblog), along with the Post's ID in the query path. If you are editing a scheduled post, make sure to include its publish_on value.
https://github.com/tumblr/docs/blob/master/api.md#postspost-id---editing-a-post-neue-post-format

can_be_tipped
community_label_categories
has_community_label
hide_trail
interactability_reblog
placement_id (and possibly earned_id?)
send_to_twitter

#827 #839

[marcustyphoon]

proposal:

import { filterPropsForEditing } from './util/something.js'

const {
  response: {
    tags = [],
    ...rest
  }
} = await apiFetch(`/v2/blog/${uuid}/posts/${postId}`);

tags.push(...tagsToAdd);

try {
  const { response: { displayText } } = await apiFetch(`/v2/blog/${uuid}/posts/${postId}`, {
    method: 'PUT',
    body: {
      ...filterPropsForEditing(rest),
      tags: tags.join(','),
    }
  });
}

[marcustyphoon]

Fixed by #879, though I still think this should be fixed in Tumblr's back end.