-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass Privater: Add mass unprivate functionality #1639
base: master
Are you sure you want to change the base?
Conversation
apiFetch(`/v2/blog/${uuid}/posts/${postData.id}`, { | ||
method: 'PUT', | ||
body: { | ||
...createEditRequestBody(postData), | ||
state: 'published' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm. the fact that this will only work on NPF/text/answer posts is... concerning.
i feel like we should have a separate "incompatible" count to show to the user, rather than trying to action on them here, knowing that the operation will always fail.
do we have a util for NPF compatibility yet? i feel like we need one.
if a post is stored in blocks format, or the original type is text, or the original type is note, it should be editable via NPF endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, shoot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And yes we do; it currently returns isBlocksPostFormat || shouldOpenInLegacy === false;
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be a <table>
...?
5be6337
to
977a7e7
Compare
Description
Per a number of user requests, this adds the ability to unprivate posts to Mass Privater, including by tag. There's currently no realistic way to do this without an extension, since you can't find all of your private posts (that contain a certain tag or otherwise) through the Tumblr UI. No, it's not fast, but it's faster than manually scrolling through your archive, that's for sure.
Resolves #1626.
Currently contains the diff of #1610; must be rebased after it is merged (or close it if merged first).Testing steps