Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Tags: Post action popup persists (minor) #1556

Open
marcustyphoon opened this issue Jul 31, 2024 · 0 comments
Open

Quick Tags: Post action popup persists (minor) #1556

marcustyphoon opened this issue Jul 31, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@marcustyphoon
Copy link
Collaborator

Platform

macOS 14.4.1 arm64

Browser

Chrome 126.0.6478.183

Addon version

1.0.1

Details

  • Open the post form
  • Open the Quick Tags popup
  • Close the post form
  • [time passes]
  • Open the post form
  • Observe that the Quick Tags popup is open without being clicked on

This is because the post actions utility reuses the same button element each time the user opens the post form, and the opened/closed state of the post action popup is stored as "is it attached to the button or not" since it uses the same code as the regular post popup.

const togglePostOptionPopupDisplay = async function ({ target, currentTarget }) {
if (target === postOptionPopupElement || postOptionPopupElement.contains(target)) { return; }
if (currentTarget.contains(postOptionPopupElement)) {
currentTarget.removeChild(postOptionPopupElement);
} else {
appendWithoutViewportOverflow(postOptionPopupElement, currentTarget);
}
};

@marcustyphoon marcustyphoon added bug Something isn't working help wanted Extra attention is needed labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant