Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for English (i18n) #53

Open
ryzzaki opened this issue Mar 16, 2020 · 7 comments · May be fixed by #265
Open

Implement support for English (i18n) #53

ryzzaki opened this issue Mar 16, 2020 · 7 comments · May be fixed by #265
Assignees
@landovsky @ryzzaki
Labels
priority This feature is crutial for current project's phase. ready for dev This user story/bug has been validated by product owner and is ready to be developed.

Comments

@ryzzaki
Copy link
Contributor

ryzzaki commented Mar 16, 2020 •
edited
Loading

This is a low priority task. All translations are currently available in comments on Figma.
@davidvobecky
Copy link

Comments resolved. You can see them used in this new english version of the landing page - Figma.

@ryzzaki
Copy link
Contributor Author

ryzzaki commented Mar 16, 2020

Thanks, @davidvobecky! @Vratislav Can you please mark this as ready for dev? I have never coded i18n but I could attempt it if someone prompts me in the right direction.

@Vratislav Vratislav added the ready for dev This user story/bug has been validated by product owner and is ready to be developed. label Mar 17, 2020
@Applifting Applifting deleted a comment from allcontributors bot Mar 17, 2020
@Vratislav
Copy link
Contributor

@all-contributors please add @ryzzaki for code translation

@allcontributors allcontributors bot mentioned this issue Mar 17, 2020
Merged
@allcontributors
Copy link
Contributor

@Vratislav

I've put up a pull request to add @ryzzaki! 🎉

@vaclavpavlicek
Copy link
Collaborator

@ryzzaki are you working on it?

@ryzzaki
Copy link
Contributor Author

ryzzaki commented Mar 23, 2020 •
edited
Loading

@ryzzaki are you working on it?

@vaclavpavlicek nope, it's up for takes. I don't really have the know how or the best practices for this 😅
You can find the translations here. They are proof read and completed.

@ryzzaki ryzzaki added the priority This feature is crutial for current project's phase. label Apr 21, 2020
@ryzzaki
Copy link
Contributor Author

ryzzaki commented Apr 21, 2020

@landovsky In order to progress with the UK expansion, this issue needs to be a bit fast tracked as it is currently a blocking task in our UK phase.

@landovsky landovsky linked a pull request Apr 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@landovsky landovsky

@ryzzaki ryzzaki

Labels
priority This feature is crutial for current project's phase. ready for dev This user story/bug has been validated by product owner and is ready to be developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

English translation, locale setup, new logo and favicons Applifting/pomuzeme.si
5 participants
@Vratislav @landovsky @vaclavpavlicek @ryzzaki @davidvobecky