Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Involvement sections #249

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Involvement sections #249

wants to merge 25 commits into from

Conversation

vaclavpavlicek
Copy link
Collaborator

Closes #205

Needs to update developer list

@landovsky
Copy link
Contributor

@vaclavpavlicek it looks pretty good to me! I like the idea with volunteer profile pictures. Can I have a couple of small suggestions?

  1. if the volunteer profile pictures were in a separate directory, it would feel better organised
  2. the Partneři anchor link is broken now

Again, good idea with the cover photos, but if you don't mind I'll run it through David the designer - maybe he'll have some design suggestions how to tidy it up.

As to the code, I'll leave a review on @pmalak front-end master if he can spare some time.

@landovsky
Copy link
Contributor

@vaclavpavlicek
Copy link
Collaborator Author

vaclavpavlicek commented Apr 15, 2020

@landovsky ok I see. I will take a look at it later today or tomorrow. 🙂

@vaclavpavlicek
Copy link
Collaborator Author

@landovsky I finally managed to fix it. Could you please take a look at descriptions of organizations?

@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   20.37%   20.37%           
=======================================
  Files         111      111           
  Lines        2376     2376           
=======================================
  Hits          484      484           
  Misses       1892     1892           
Flag Coverage Δ
#unittests 100.00% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26450f...f538f33. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #249 into master will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   34.00%   33.66%   -0.34%     
==========================================
  Files         103      103              
  Lines        2179     2201      +22     
==========================================
  Hits          741      741              
- Misses       1438     1460      +22     
Flag Coverage Δ
#unittests 100.00% <ø> (ø)
Impacted Files Coverage Δ
app/controllers/home_controller.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fb311...ce8804b. Read the comment docs.

@vaclavpavlicek
Copy link
Collaborator Author

@pmalak could you please take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Kdo je zapojen do projektu" section
5 participants