Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetStandard1.0 dll in v5.0-alpha nupkg [Polly5.0.2] is stamped 0.0.0.0 #176

Closed
reisenberger opened this issue Nov 11, 2016 · 1 comment
Closed

Comments

@reisenberger
Copy link
Member

reisenberger commented Nov 11, 2016

The GitVersionTask tool we use to stamp assemblies with version number does not yet support assemblies targeting .NET Standard.

This means that Polly.dll in our .NETStandard-targeting Nuget packages is currently version-numbered 0.0.0.0. (Nuget package number is correct; AssemblyVersion info on Polly.dll (the dll targeting NetStandard 1.0 only) reads 0.0.0.0)

Options:

[1] Continue to live with this
[2] Keep [assembly: AssemblyVersion("5.0.2.0")] in Polly.NetStandard10\AssemblyInfo.cs manually in sync with GitVersionConfig.yaml (two sources of truth) (until GitVersionTask fix this)
[3] [preferred for now?] Add some automated regex replace step in the build, to copy the version number from GitVersionConfig.yaml (single source of truth) to Polly.NetStandard10\AssemblyInfo.cs (until GitVersionTask fix this)
[4] Switch to https://github.com/SimpleGitVersion/SGV-Net. Claims to handle this scenario, but has more limited following than GitVersionTask.

Clearly, with the whole project.json / csproj tooling in flux, we can expect to have to change this again - any solution is temporary.

GitVersionTask folks are (probably wisely) holding off fixing, until the Net Standard project formats/tooling settle.

reisenberger pushed a commit to reisenberger/Polly that referenced this issue Nov 11, 2016
@reisenberger
Copy link
Member Author

Fixed in Polly v5.0.2 on nuget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant