New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue[Upstream] Build failure: due to SOME TEMPLATE CODE ISSUES #8

Open

technoshantoms opened this issue Nov 25, 2024 · 0 comments · May be fixed by #10

Assignees

technoshantoms commented Nov 25, 2024

In fc/include/fc/io/datastream.hpp, in the datastream template, there are calls to this->pubseekoff which doesn't exist.

They were clearly supposed to be to buf.pubseekoff instead.

Seems they got away with it because it's a template and it wasn't instantiated, but if that template is instantiated, it fails to build.

Just unconditionally replace the this->pubseekoff references with buf.pubseekoff and it works fine.

greg7mdp self-assigned this

technoshantoms changed the title ~~Issue[Upstream] Build failure~~ Issue[Upstream] Build failure: due to SOME TEMPLATE CODE ISSUES

greg7mdp linked a pull request

that will close this issue

Fix typo calling this->pubseekoff instead of buf.pubseekoff #10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment