Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template auto parameter should not pass type #3

Closed
huangminghuang opened this issue Oct 3, 2022 · 1 comment · Fixed by #4
Closed

template auto parameter should not pass type #3

huangminghuang opened this issue Oct 3, 2022 · 1 comment · Fixed by #4
Labels
OCI Work exclusive to OCI team

Comments

@huangminghuang
Copy link
Contributor

In function_traits.hpp:105, the template function is_callable_v is declared to accept an auto parameter; however, the calling side is passed a type parameter decltype(fn) which causes a compiler error on Apple clang version 14. The code should be changed to if constexpr (is_callable(fn)) instead.
@heifner
Copy link
Member

heifner commented Oct 3, 2022

Related: EOSIO/eos-vm#210

@stephenpdeos stephenpdeos moved this to Todo in Team Backlog Oct 6, 2022
@stephenpdeos stephenpdeos added the OCI Work exclusive to OCI team label Oct 6, 2022
@heifner heifner mentioned this issue Oct 7, 2022
Merged
2 tasks
@stephenpdeos stephenpdeos moved this from Todo to Awaiting Review in Team Backlog Oct 27, 2022
Repository owner moved this from Awaiting Review to Done in Team Backlog Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix is_callable_v AntelopeIO/eos-vm
3 participants
@huangminghuang @heifner @stephenpdeos