Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Separate ground wire procedure from ProtectiveMaterialReplacement #1236

Open
dbirman opened this issue Jan 14, 2025 · 7 comments · May be fixed by #1243
Open

[2.0] Separate ground wire procedure from ProtectiveMaterialReplacement #1236

dbirman opened this issue Jan 14, 2025 · 7 comments · May be fixed by #1243
Assignees
Labels
breaking Breaking changes

Comments

@dbirman
Copy link
Member

dbirman commented Jan 14, 2025

No description provided.

@dbirman dbirman added this to the v2.0 milestone Jan 14, 2025
@dbirman dbirman added the breaking Breaking changes label Jan 15, 2025
@dbirman
Copy link
Member Author

dbirman commented Jan 16, 2025

@saskiad not sure what this field is supposed to describe: ground_wire_hole: Optional[int] = Field(default=None, title="Ground wire hole"). Is this the number of holes? I think we should add a description

@saskiad
Copy link
Collaborator

saskiad commented Jan 16, 2025

This is which hole in the implant the ground wire is inserted into. It's fairly specific to how our ephys team does whole hemisphere/dual hemisphere recordings with the implants that they use. So perhaps a description of "Implant hole number ground wire inserted in"? something like that?

@dbirman dbirman self-assigned this Jan 16, 2025
@saskiad
Copy link
Collaborator

saskiad commented Jan 16, 2025

is it possible we want this to be part of an AIND ephys extension?

@dbirman
Copy link
Member Author

dbirman commented Jan 16, 2025

I think this is exactly what we want in extensions

@saskiad
Copy link
Collaborator

saskiad commented Jan 16, 2025

That's true for the replacing protective material as well.

@saskiad
Copy link
Collaborator

saskiad commented Jan 16, 2025

I'm not 100% sure that replacing the protective material needs to be tracked in metadata. It's part of the protocol, so just saying that it happens feels like overkill. If someone feels strongly that we need a strong label of the protective material in the metadata, we can keep it, but I'm inclined not to. The position of the ground wire feels both more variable and more salient to interpreting the data.

@dbirman
Copy link
Member Author

dbirman commented Jan 17, 2025

I'm not 100% sure that replacing the protective material needs to be tracked in metadata. It's part of the protocol, so just saying that it happens feels like overkill. If someone feels strongly that we need a strong label of the protective material in the metadata, we can keep it, but I'm inclined not to. The position of the ground wire feels both more variable and more salient to interpreting the data.

Okay I'll take it out entirely then and leave just the ground wire implant, with the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment