From f457a4566572456c9ee22da8df4e3e99b0d474bf Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Mon, 3 Jun 2024 14:54:24 -0700 Subject: [PATCH 01/11] chore: Checks workflow --- .github/workflows/checks.yml | 95 ++++++++++++++++++++++++++++++ package.json | 4 +- packages/geometry/package.json | 3 +- packages/scatterbrain/package.json | 3 +- 4 files changed, 102 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/checks.yml diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml new file mode 100644 index 0000000..ccf1652 --- /dev/null +++ b/.github/workflows/checks.yml @@ -0,0 +1,95 @@ +name: Checks + +on: [pull_request] + +concurrency: + # Cancels workflows that are already running when a new one is triggered for a branch + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + build: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' + + - name: Install dependencies + run: pnpm install --frozen-lockfile + + - name: Build + run: pnpm build + + format: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' + + - name: Install dependencies + run: pnpm install --frozen-lockfile + + - name: Format + run: echo "Add pnpm fmt command here" + + lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' + + - name: Install dependencies + run: pnpm install --frozen-lockfile + + - name: Lint + run: echo "Add pnpm lint command here" + + test: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' + + - name: Install dependencies + run: pnpm install --frozen-lockfile + + - name: Test + run: pnpm test + + typecheck: + needs: build + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' + + - name: Install dependencies + run: pnpm install --frozen-lockfile + + - name: Typecheck + run: pnpm typecheck diff --git a/package.json b/package.json index db7ade0..2dc9e57 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,9 @@ "scripts": { "preinstall": "npx only-allow pnpm", "build": "pnpm -r run build", - "watch": "pnpm -r run watch" + "watch": "pnpm -r run watch", + "test": "pnpm -r run test:ci", + "typecheck": "pnpm -r run typecheck" }, "devDependencies": { "@parcel/packager-ts": "2.12.0", diff --git a/packages/geometry/package.json b/packages/geometry/package.json index a2b0dda..87efe1d 100644 --- a/packages/geometry/package.json +++ b/packages/geometry/package.json @@ -36,7 +36,8 @@ "typecheck": "tsc --noEmit", "build": "parcel build --no-cache", "watch": "parcel watch", - "test": "vitest --watch" + "test": "vitest --watch", + "test:ci": "vitest run" }, "repository": { "type": "git", diff --git a/packages/scatterbrain/package.json b/packages/scatterbrain/package.json index c965589..7cc3363 100644 --- a/packages/scatterbrain/package.json +++ b/packages/scatterbrain/package.json @@ -36,7 +36,8 @@ "typecheck": "tsc --noEmit", "build": "parcel build --no-cache", "watch": "parcel watch", - "test": "vitest --watch" + "test": "vitest --watch", + "test:ci": "vitest run" }, "repository": { "type": "git", From 535f776302337ceb43864fafcdc5c3e30832d32a Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Mon, 3 Jun 2024 14:58:39 -0700 Subject: [PATCH 02/11] Add install for pnpm --- .github/workflows/checks.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index ccf1652..ab9f316 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -14,6 +14,11 @@ jobs: steps: - uses: actions/checkout@v3 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 + - name: Use Node.js uses: actions/setup-node@v3 with: @@ -31,6 +36,11 @@ jobs: steps: - uses: actions/checkout@v3 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 + - name: Use Node.js uses: actions/setup-node@v3 with: @@ -48,6 +58,11 @@ jobs: steps: - uses: actions/checkout@v3 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 + - name: Use Node.js uses: actions/setup-node@v3 with: @@ -65,6 +80,11 @@ jobs: steps: - uses: actions/checkout@v3 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 + - name: Use Node.js uses: actions/setup-node@v3 with: @@ -83,6 +103,11 @@ jobs: steps: - uses: actions/checkout@v3 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 + - name: Use Node.js uses: actions/setup-node@v3 with: From 52d41afa4c22af2c82e51364e3a8f22b89cd8aef Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Mon, 3 Jun 2024 15:14:56 -0700 Subject: [PATCH 03/11] Oops, had a dependency I didn't need --- .github/workflows/checks.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index ab9f316..3887286 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -97,7 +97,6 @@ jobs: run: pnpm test typecheck: - needs: build runs-on: ubuntu-latest steps: From 6f418307247b5cb0eab5db72d6c3f2691da19dce Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Tue, 18 Jun 2024 11:47:37 -0700 Subject: [PATCH 04/11] Run fmt:check command --- .github/workflows/checks.yml | 2 +- package.json | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 3887286..b7ee09c 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -50,7 +50,7 @@ jobs: run: pnpm install --frozen-lockfile - name: Format - run: echo "Add pnpm fmt command here" + run: pnpm fmt:check lint: runs-on: ubuntu-latest diff --git a/package.json b/package.json index 8e2fbea..e9950d9 100644 --- a/package.json +++ b/package.json @@ -4,10 +4,10 @@ "preinstall": "npx only-allow pnpm", "build": "pnpm -r run --no-bail build", "watch": "pnpm -r run watch", - "test": "pnpm -r run --no-bail test:ci", - "typecheck": "pnpm -r --no-bail run typecheck", "fmt": "npx prettier . --write", - "fmt:check": "npx prettier . --check" + "fmt:check": "npx prettier . --check", + "test": "pnpm -r run --no-bail test:ci", + "typecheck": "pnpm -r --no-bail run typecheck" }, "devDependencies": { "@parcel/packager-ts": "2.12.0", From 563cc2f3c709dd80f31f4cb85f2af873d9c5c500 Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Tue, 18 Jun 2024 13:39:43 -0700 Subject: [PATCH 05/11] fmt --- .github/workflows/checks.yml | 160 +++++++++++++++++------------------ 1 file changed, 80 insertions(+), 80 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index b7ee09c..6f86080 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -8,112 +8,112 @@ concurrency: cancel-in-progress: true jobs: - build: - runs-on: ubuntu-latest + build: + runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - version: 9 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 - - name: Use Node.js - uses: actions/setup-node@v3 - with: - node-version: '18' + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' - - name: Install dependencies - run: pnpm install --frozen-lockfile + - name: Install dependencies + run: pnpm install --frozen-lockfile - - name: Build - run: pnpm build + - name: Build + run: pnpm build - format: - runs-on: ubuntu-latest + format: + runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - version: 9 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 - - name: Use Node.js - uses: actions/setup-node@v3 - with: - node-version: '18' + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' - - name: Install dependencies - run: pnpm install --frozen-lockfile + - name: Install dependencies + run: pnpm install --frozen-lockfile - - name: Format - run: pnpm fmt:check + - name: Format + run: pnpm fmt:check - lint: - runs-on: ubuntu-latest + lint: + runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - version: 9 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 - - name: Use Node.js - uses: actions/setup-node@v3 - with: - node-version: '18' + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' - - name: Install dependencies - run: pnpm install --frozen-lockfile + - name: Install dependencies + run: pnpm install --frozen-lockfile - - name: Lint - run: echo "Add pnpm lint command here" + - name: Lint + run: echo "Add pnpm lint command here" - test: - runs-on: ubuntu-latest + test: + runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - version: 9 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 - - name: Use Node.js - uses: actions/setup-node@v3 - with: - node-version: '18' + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' - - name: Install dependencies - run: pnpm install --frozen-lockfile + - name: Install dependencies + run: pnpm install --frozen-lockfile - - name: Test - run: pnpm test + - name: Test + run: pnpm test - typecheck: - runs-on: ubuntu-latest + typecheck: + runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + steps: + - uses: actions/checkout@v3 - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - version: 9 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 9 - - name: Use Node.js - uses: actions/setup-node@v3 - with: - node-version: '18' + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '18' - - name: Install dependencies - run: pnpm install --frozen-lockfile + - name: Install dependencies + run: pnpm install --frozen-lockfile - - name: Typecheck - run: pnpm typecheck + - name: Typecheck + run: pnpm typecheck From a7bb5a2dc5657adb599771d97a4794cac019557f Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:54:00 -0700 Subject: [PATCH 06/11] Update CI file --- .github/workflows/{checks.yml => ci.yml} | 34 +++++++++++++----------- 1 file changed, 19 insertions(+), 15 deletions(-) rename .github/workflows/{checks.yml => ci.yml} (76%) diff --git a/.github/workflows/checks.yml b/.github/workflows/ci.yml similarity index 76% rename from .github/workflows/checks.yml rename to .github/workflows/ci.yml index 6f86080..76d56b1 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 @@ -20,9 +20,9 @@ jobs: version: 9 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '22' - name: Install dependencies run: pnpm install --frozen-lockfile @@ -31,10 +31,11 @@ jobs: run: pnpm build format: + name: Format runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 @@ -42,9 +43,9 @@ jobs: version: 9 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '22' - name: Install dependencies run: pnpm install --frozen-lockfile @@ -53,10 +54,11 @@ jobs: run: pnpm fmt:check lint: + name: Lint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 @@ -64,9 +66,9 @@ jobs: version: 9 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '22' - name: Install dependencies run: pnpm install --frozen-lockfile @@ -75,10 +77,11 @@ jobs: run: echo "Add pnpm lint command here" test: + name: Test runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 @@ -86,9 +89,9 @@ jobs: version: 9 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '22' - name: Install dependencies run: pnpm install --frozen-lockfile @@ -97,10 +100,11 @@ jobs: run: pnpm test typecheck: + name: Typecheck runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install pnpm uses: pnpm/action-setup@v4 @@ -108,9 +112,9 @@ jobs: version: 9 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '22' - name: Install dependencies run: pnpm install --frozen-lockfile From 28796a03bfdf2b319159d504f66aa07262c86f5d Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:54:49 -0700 Subject: [PATCH 07/11] change name --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 76d56b1..96a235a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,4 +1,4 @@ -name: Checks +name: CI on: [pull_request] From 2394856df4a6fc86a372c2bbc83471ed630c8748 Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:56:29 -0700 Subject: [PATCH 08/11] fmt --- LICENSE.md | 4 ++-- examples/package.json | 2 +- packages/dzi/package.json | 2 +- packages/dzi/src/loader.ts | 16 ++++++++-------- packages/dzi/src/renderer.ts | 2 +- packages/geometry/package.json | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/LICENSE.md b/LICENSE.md index 0745566..45200b7 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,4 +1,4 @@ -Copyright 2024 Allen Institute +Copyright 2024 Allen Institute Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: @@ -8,4 +8,4 @@ Redistribution and use in source and binary forms, with or without modification, 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. \ No newline at end of file +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. diff --git a/examples/package.json b/examples/package.json index fb913ea..19aa863 100644 --- a/examples/package.json +++ b/examples/package.json @@ -64,4 +64,4 @@ "regl": "^2.1.0", "zarrita": "0.4.0-next.14" } -} \ No newline at end of file +} diff --git a/packages/dzi/package.json b/packages/dzi/package.json index dd7e021..dfdc05b 100644 --- a/packages/dzi/package.json +++ b/packages/dzi/package.json @@ -55,4 +55,4 @@ "lodash": "^4.17.21", "regl": "^2.1.0" } -} \ No newline at end of file +} diff --git a/packages/dzi/src/loader.ts b/packages/dzi/src/loader.ts index 0edda84..1ebb9b3 100644 --- a/packages/dzi/src/loader.ts +++ b/packages/dzi/src/loader.ts @@ -54,13 +54,13 @@ export function getVisibleTiles(dzi: DziImage, camera: { view: box2D; screenSize const availableTiles = tilesInLayer(dzi, layer); const baseLayer = findLargestSingleTileLayer(dzi); - const baseIndex: TileIndex = { col: 0, row: 0 } + const baseIndex: TileIndex = { col: 0, row: 0 }; const baseTile: DziTile = { index: baseIndex, layer: baseLayer, relativeLocation: Box2D.create([0, 0], [1, 1]), - url: tileUrl(dzi, baseLayer, baseIndex) - } + url: tileUrl(dzi, baseLayer, baseIndex), + }; // note that the tile boxes are in pixels relative to the layer in which they reside // the given view is assumed to be a parameter (in the space [0:1]) of the image as a whole @@ -82,7 +82,7 @@ export function getVisibleTiles(dzi: DziImage, camera: { view: box2D; screenSize // filter out tiles which are not in view }) .filter((t) => !!Box2D.intersection(t.relativeLocation, camera.view)); - return (baseLayer < layer) ? [baseTile, ...tiles] : tiles; + return baseLayer < layer ? [baseTile, ...tiles] : tiles; } /** * NOTE: THE REMAINDER OF THIS FILE IS EXPORTED ONLY FOR TESTING PURPOSES @@ -97,13 +97,13 @@ export function firstSuitableLayer(imageWidth: number, screenWidth: number) { } /** - * - * @param dzi + * + * @param dzi * @returns the index of the largest layer which contains only a single tile - * + * */ function findLargestSingleTileLayer(dzi: DziImage): number { - return Math.floor(Math.log2(dzi.tileSize)) + return Math.floor(Math.log2(dzi.tileSize)); } export function tileWithOverlap(total: number, step: number, overlap: number): Interval[] { const blocks: Interval[] = []; diff --git a/packages/dzi/src/renderer.ts b/packages/dzi/src/renderer.ts index 4962a41..1937ad0 100644 --- a/packages/dzi/src/renderer.ts +++ b/packages/dzi/src/renderer.ts @@ -45,7 +45,7 @@ export function buildDziRenderer(regl: REGL.Regl): Renderer { }, // no private resources to destroy + destroy: () => {}, // no private resources to destroy cacheKey: (item, _requestKey, _data, _settings) => `${item.url}`, fetchItemContent: fetchDziTile, getVisibleItems: (dzi, settings) => { diff --git a/packages/geometry/package.json b/packages/geometry/package.json index f7ed500..00783d6 100644 --- a/packages/geometry/package.json +++ b/packages/geometry/package.json @@ -52,4 +52,4 @@ "typescript": "^5.3.3", "vitest": "^1.4.0" } -} \ No newline at end of file +} From 2cc5aa68d2e106bba2435e68cbf3c0e433f6ed48 Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:57:26 -0700 Subject: [PATCH 09/11] Build on typecheck step --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 96a235a..bb29dc2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -119,5 +119,8 @@ jobs: - name: Install dependencies run: pnpm install --frozen-lockfile + - name: Build + run: pnpm build + - name: Typecheck run: pnpm typecheck From e4bc790b5fc5341d32adf592f1f477f1f202b574 Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:57:47 -0700 Subject: [PATCH 10/11] name for Build job --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bb29dc2..02600db 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,7 @@ concurrency: jobs: build: + name: Build runs-on: ubuntu-latest steps: From ae9bc95fa91623521a97ef811a44e5f086b460d6 Mon Sep 17 00:00:00 2001 From: Lane Sawyer Date: Thu, 31 Oct 2024 15:59:56 -0700 Subject: [PATCH 11/11] Skip lint job since we don't have a linter yet --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 02600db..7176b50 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,6 +57,8 @@ jobs: lint: name: Lint runs-on: ubuntu-latest + # Skip job until we get a linter added + if: false steps: - uses: actions/checkout@v4