Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: server managed vanilla item id #580

Open
smartcmd opened this issue Feb 24, 2025 · 0 comments
Open

proposal: server managed vanilla item id #580

smartcmd opened this issue Feb 24, 2025 · 0 comments
Labels
Proposal Some important decisions Refactor

Comments

@smartcmd
Copy link
Member

smartcmd commented Feb 24, 2025

Overview

Currently, for vanilla item types, Allay assigns the same runtime ids as the vanilla. However, since item id is decided server-side, we can just use an id counter to assign the runtime id. This change will remove the runtimeId field in ItemId enum to prevent users from using these numerical ids, as these numerical ids are not expected to be used by users (they may change between different protocol version).

Although in most of the cases, the protocol layer have stop using numerical ids, the effect of this change is unknown. Most of the 3rd bedrock server implementation still using the same runtime id as the vanilla. Before further work, it is necessary to investigate the unintended impacts this change may result from.

@smartcmd smartcmd added Proposal Some important decisions Refactor labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Some important decisions Refactor
Projects
None yet
Development

No branches or pull requests

1 participant