Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tune" menu commands should accept "node" arg and pre-select interface settings #408

Closed
Allan-N opened this issue Sep 24, 2024 · 2 comments · Fixed by #409
Closed

"tune" menu commands should accept "node" arg and pre-select interface settings #408

Allan-N opened this issue Sep 24, 2024 · 2 comments · Fixed by #409
Labels
enhancement New feature or request

Comments

@Allan-N
Copy link
Collaborator

Allan-N commented Sep 24, 2024

On systems with a single node, trying to use the simpleusb-tune-menu (or radio-tune-menu) command to "tune" the audio interface is a simple matter. This is because there is only one node/interface to configure. The configuration process gets more complicated when you have more than one node because the menu commands and channel driver(s) don't know which node you want to display/update. Without this pre-selection the user is presented with settings for "a" interface but not necessarily the interface they are hoping to view/update.

We can/should make this simpler. I propose that we add a "-n " argument to the tune commands that would be used to select the node/interface configuration being viewed/updated.

With that functionality in place we can update the node-setup menu to pass this new argument when tuning the interface for a specific node.

@Allan-N Allan-N added the enhancement New feature or request label Sep 24, 2024
@encbar5
Copy link
Collaborator

encbar5 commented Sep 24, 2024

Is this going to be available from the Asterisk CLI as well?

@Allan-N
Copy link
Collaborator Author

Allan-N commented Sep 24, 2024

The simpleusb-tune-menu command provide selection "1" to select the USB device. This uses a combination of the following CLI commands :

  • susb active
  • susb tune menu-support 1
  • susb active <node>

My proposal would simply be exec'ing "susb active", checking if the currently selected device is what was requested with the command line argument, and changing the selected device as needed.

And, to answer your question, you can already do this with the Asterisk CLI :-)

@Allan-N Allan-N linked a pull request Sep 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants