From 2622e89a51132186f2256897e6918c0236352c67 Mon Sep 17 00:00:00 2001
From: openhands <neubig@gmail.com>
Date: Tue, 10 Dec 2024 20:32:02 +0000
Subject: [PATCH] Add tests for Vega-Lite chart configuration

---
 src/components/ActivityChart.test.tsx | 126 ++++++++++++++++++++++++--
 1 file changed, 118 insertions(+), 8 deletions(-)

diff --git a/src/components/ActivityChart.test.tsx b/src/components/ActivityChart.test.tsx
index bd80e1a..bc96ba4 100644
--- a/src/components/ActivityChart.test.tsx
+++ b/src/components/ActivityChart.test.tsx
@@ -3,9 +3,13 @@ import { describe, it, expect, vi } from 'vitest';
 import { ActivityChart } from './ActivityChart';
 import { BotActivity } from '../types';
 
-// Mock react-vega since it's a complex visualization component
+// Mock VegaLite component and capture the spec prop
+const mockVegaLite = vi.fn(() => <div data-testid="vega-lite-chart" />);
 vi.mock('react-vega', () => ({
-  VegaLite: vi.fn(() => <div data-testid="vega-lite-chart" />),
+  VegaLite: (props: unknown) => {
+    mockVegaLite(props);
+    return <div data-testid="vega-lite-chart" />;
+  },
 }));
 
 describe('ActivityChart', () => {
@@ -13,20 +17,59 @@ describe('ActivityChart', () => {
     {
       id: '1',
       type: 'issue',
-      status: 'success',
+      status: 'no_pr',
       timestamp: '2023-11-28T12:00:00Z',
       url: 'https://github.com/example/1',
-      title: 'ISSUE success 11/28/2023, 12:00:00 PM -- Test Issue 1',
-      description: 'Successfully resolved issue',
+      title: 'Test Issue 1',
+      description: 'Issue without PR',
     },
     {
       id: '2',
       type: 'issue',
-      status: 'failure',
+      status: 'pr_open',
       timestamp: '2023-11-28T13:00:00Z',
       url: 'https://github.com/example/2',
-      title: 'ISSUE failure 11/28/2023, 1:00:00 PM -- Test Issue 2',
-      description: 'Failed to resolve issue',
+      title: 'Test Issue 2',
+      description: 'Issue with open PR',
+      prUrl: 'https://github.com/example/pr/2',
+    },
+    {
+      id: '3',
+      type: 'issue',
+      status: 'pr_merged',
+      timestamp: '2023-11-28T14:00:00Z',
+      url: 'https://github.com/example/3',
+      title: 'Test Issue 3',
+      description: 'Issue with merged PR',
+      prUrl: 'https://github.com/example/pr/3',
+    },
+    {
+      id: '4',
+      type: 'issue',
+      status: 'pr_closed',
+      timestamp: '2023-11-28T15:00:00Z',
+      url: 'https://github.com/example/4',
+      title: 'Test Issue 4',
+      description: 'Issue with closed PR',
+      prUrl: 'https://github.com/example/pr/4',
+    },
+    {
+      id: '5',
+      type: 'pr',
+      status: 'success',
+      timestamp: '2023-11-28T16:00:00Z',
+      url: 'https://github.com/example/5',
+      title: 'Test PR 1',
+      description: 'Successful PR',
+    },
+    {
+      id: '6',
+      type: 'pr',
+      status: 'failure',
+      timestamp: '2023-11-28T17:00:00Z',
+      url: 'https://github.com/example/6',
+      title: 'Test PR 2',
+      description: 'Failed PR',
     },
   ];
 
@@ -37,4 +80,71 @@ describe('ActivityChart', () => {
 
     expect(getByTestId('vega-lite-chart')).toBeInTheDocument();
   });
+
+  it('filters activities by type', () => {
+    render(<ActivityChart activities={mockActivities} type="issue" />);
+    const lastCall = mockVegaLite.mock.lastCall[0];
+    const chartData = lastCall.spec.data.values;
+
+    // Should only include issue activities
+    expect(chartData).toHaveLength(4);
+    expect(chartData.every((d: { date: string; status: string }) => 
+      ['no_pr', 'pr_open', 'pr_merged', 'pr_closed'].includes(d.status)
+    )).toBe(true);
+  });
+
+  it('configures issue color scale correctly', () => {
+    render(<ActivityChart activities={mockActivities} type="issue" />);
+    const lastCall = mockVegaLite.mock.lastCall[0];
+    const colorScale = lastCall.spec.encoding.color.scale;
+
+    expect(colorScale.domain).toEqual(['no_pr', 'pr_open', 'pr_merged', 'pr_closed']);
+    expect(colorScale.range).toEqual(['#ffffff', '#4caf50', '#9c27b0', '#f44336']);
+  });
+
+  it('configures PR color scale correctly', () => {
+    render(<ActivityChart activities={mockActivities} type="pr" />);
+    const lastCall = mockVegaLite.mock.lastCall[0];
+    const colorScale = lastCall.spec.encoding.color.scale;
+
+    expect(colorScale.domain).toEqual(['success', 'failure']);
+    expect(colorScale.range).toEqual(['#22c55e', '#ef4444']);
+  });
+
+  it('configures chart axes correctly', () => {
+    render(<ActivityChart activities={mockActivities} type="issue" />);
+    const lastCall = mockVegaLite.mock.lastCall[0];
+    const { x, y } = lastCall.spec.encoding;
+
+    expect(x.field).toBe('date');
+    expect(x.type).toBe('temporal');
+    expect(x.title).toBe('Date');
+    expect(x.axis).toEqual({
+      labelColor: '#C4CBDA',
+      titleColor: '#C4CBDA',
+      gridColor: '#3c3c4a',
+      domainColor: '#3c3c4a'
+    });
+
+    expect(y.aggregate).toBe('count');
+    expect(y.type).toBe('quantitative');
+    expect(y.title).toBe('Count');
+    expect(y.axis).toEqual({
+      labelColor: '#C4CBDA',
+      titleColor: '#C4CBDA',
+      gridColor: '#3c3c4a',
+      domainColor: '#3c3c4a'
+    });
+  });
+
+  it('configures chart title correctly', () => {
+    render(<ActivityChart activities={mockActivities} type="issue" />);
+    const lastCall = mockVegaLite.mock.lastCall[0];
+    const { title } = lastCall.spec;
+
+    expect(title).toEqual({
+      text: 'ISSUE Activity Over Time',
+      color: '#C4CBDA'
+    });
+  });
 });
\ No newline at end of file