From 4181694083edb741d6c2bb6f50912228c936c286 Mon Sep 17 00:00:00 2001 From: openhands Date: Tue, 12 Nov 2024 19:00:09 +0000 Subject: [PATCH 1/2] Fix issue #4944: [Bug]: Missing GitHub token link in account settings --- .../src/components/modals/AccountSettingsModal.tsx | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/frontend/src/components/modals/AccountSettingsModal.tsx b/frontend/src/components/modals/AccountSettingsModal.tsx index b2adc2d7bb32..43edd08b5d2e 100644 --- a/frontend/src/components/modals/AccountSettingsModal.tsx +++ b/frontend/src/components/modals/AccountSettingsModal.tsx @@ -87,6 +87,17 @@ function AccountSettingsModal({ type="password" defaultValue={data?.ghToken ?? ""} /> + + {t(I18nKey.CONNECT_TO_GITHUB_MODAL$GET_YOUR_TOKEN)}{" "} + + {t(I18nKey.CONNECT_TO_GITHUB_MODAL$HERE)} + + {gitHubError && (

{t(I18nKey.ACCOUNT_SETTINGS_MODAL$GITHUB_TOKEN_INVALID)} From 3dde4942debf1883125983602f7796add62c18f6 Mon Sep 17 00:00:00 2001 From: amanape <83104063+amanape@users.noreply.github.com> Date: Tue, 12 Nov 2024 21:05:32 +0200 Subject: [PATCH 2/2] Consistent styles --- frontend/src/components/modals/AccountSettingsModal.tsx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/frontend/src/components/modals/AccountSettingsModal.tsx b/frontend/src/components/modals/AccountSettingsModal.tsx index 43edd08b5d2e..558966777bda 100644 --- a/frontend/src/components/modals/AccountSettingsModal.tsx +++ b/frontend/src/components/modals/AccountSettingsModal.tsx @@ -1,7 +1,10 @@ import { useFetcher, useRouteLoaderData } from "@remix-run/react"; import React from "react"; import { useTranslation } from "react-i18next"; -import { BaseModalTitle } from "./confirmation-modals/BaseModal"; +import { + BaseModalDescription, + BaseModalTitle, +} from "./confirmation-modals/BaseModal"; import ModalBody from "./ModalBody"; import ModalButton from "../buttons/ModalButton"; import FormFieldset from "../form/FormFieldset"; @@ -87,7 +90,7 @@ function AccountSettingsModal({ type="password" defaultValue={data?.ghToken ?? ""} /> - + {t(I18nKey.CONNECT_TO_GITHUB_MODAL$GET_YOUR_TOKEN)}{" "} {t(I18nKey.CONNECT_TO_GITHUB_MODAL$HERE)} - + {gitHubError && (

{t(I18nKey.ACCOUNT_SETTINGS_MODAL$GITHUB_TOKEN_INVALID)}