Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Keep prompt after project upload or repo selection #4925

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 12, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
If user types prompt then uploads a project, the query is never stored and sent.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Submit query a project is uploaded or a repo is selected, (form submission triggers the clientAction)

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:557b785-nikolaik   --name openhands-app-557b785   docker.all-hands.dev/all-hands-ai/openhands:557b785

@amanape amanape requested a review from tofarr November 12, 2024 10:28
@amanape amanape self-assigned this Nov 12, 2024
@rbren
Copy link
Collaborator

rbren commented Nov 14, 2024

This didn't work for me when attaching a github repo unfortunately

@rbren
Copy link
Collaborator

rbren commented Nov 14, 2024

does seem to work correctly for zip upload though!

@amanape amanape changed the title feat(frontend): Keep prompt after project upload feat(frontend): Keep prompt after project upload or repo selection Nov 15, 2024
@amanape amanape requested a review from rbren November 15, 2024 09:05
onMount: EditorProps["onMount"];
isReadOnly: boolean;
}

function CodeEditorCompoonent({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@amanape amanape merged commit ffc4d32 into main Nov 15, 2024
16 checks passed
@amanape amanape deleted the ALL-692/keep-prompt-after-upload branch November 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants