Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Just clicking and browsing Workspace files cause them to have the "edited dot" next the file name #4808

Closed
1 task done
diwu-sf opened this issue Nov 6, 2024 · 8 comments
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working severity:medium Affecting multiple users

Comments

@diwu-sf
Copy link
Contributor

diwu-sf commented Nov 6, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

On latest main commit 2b3fd94
In the UI, load up the workspace and just click around the files will cause them to have the "edited dot".

image

OpenHands Installation

Docker command in README

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@diwu-sf diwu-sf added the bug Something isn't working label Nov 6, 2024
@enyst
Copy link
Collaborator

enyst commented Nov 6, 2024

Maybe @amanape has an idea why that happens?

@mamoodi
Copy link
Collaborator

mamoodi commented Nov 7, 2024

Huh... interesting that you are seeing this while nothing is running.
There is a related issue here: #4576

@mamoodi mamoodi added the severity:medium Affecting multiple users label Nov 7, 2024
@diwu-sf
Copy link
Contributor Author

diwu-sf commented Nov 14, 2024

The easiest way to reproduce this is to make a fully empty .gitkeep file (touch .gitkeep) and then click the gitkeep file in the UI

@diwu-sf
Copy link
Contributor Author

diwu-sf commented Nov 22, 2024

@enyst @mamoodi
This is still happening, there's something wrong with handleEditorChange callback, and the value that's being set.

I think there's a race condition with the fetch for the new file, because what I see after adding logging is:

  • when clicking away from a file path
  • handleEditorChange is called with the previous file path, but the content of the new file clicked into

@amanape
Copy link
Member

amanape commented Nov 22, 2024

@diwu-sf Nobody has taken on the issue yet, sorry! I'll give it a good look on Monday but can't make any promises.

@diwu-sf
Copy link
Contributor Author

diwu-sf commented Nov 27, 2024

Bump, this is a pretty severe bug that's still reproducible on main.
I think it has to do with random ordering of the event callback for the editor.
When it reproduces, the frontend file content state cache is constantly getting the "new file content" set against the previous file's path when a new file is clicked into in the tree list.

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 27, 2024

This is fixed in main because the UI no longer allows you to edit files.

@mamoodi mamoodi added the awaiting release Fixed in main. Waiting for release. label Dec 27, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 2, 2025

Fixed in 0.18.0.

@mamoodi mamoodi closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working severity:medium Affecting multiple users
Projects
None yet
Development

No branches or pull requests

4 participants