Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1104 input signal issue #3

Open
AlkaMotors opened this issue Apr 11, 2019 · 3 comments
Open

1104 input signal issue #3

AlkaMotors opened this issue Apr 11, 2019 · 3 comments

Comments

@AlkaMotors
Copy link
Owner

@conuthead
running at 1104 input , has breaks from time to time (motor stops spinning for ca 120ms)
if you spin slightly higher or lower it does not happen !

DS6_QuickPrint9

DS6_QuickPrint8

yellow is proshot imput
light blue is computeProshotDMA (at function begin)
magenta is calcCRC == checkCRC
dark blue is motor output

Originally posted by @adrianmiriuta in #1 (comment)

@AlkaMotors
Copy link
Owner Author

OK, it was frame corruption that was causing the issue. The 1104 input signal is the same as dshot number 256. When a corrupt frame would happen the dshot number was calculated a 8 bits less and the crc did not pick it up. The dshot number would be read as a 0 which would stop the esc until the zero cross time out happens and the esc restart. I have worked around by just requiring two correct signals in a row for the dshot numbers 0 - 47. I will push changes when i have tested a bit more.

@adrianmiriuta
Copy link

@conuthead
cool

@AlkaMotors
Copy link
Owner Author

OK, the fixed code is up for the signal corruption in dshot and proshot. The next plan I will decrease the buffer length to capture a single signal instead of a double length buffer.
Thanks for noticing the corruption! That was a major problem. I did not notice in my testing as I am using a servo input signal. That issue had the potential to make the motor start running backwards !
The changed version runs much better throughout the rpm range now. I still don't know about how high it can go erpm but motors are on the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants