Add support for Ed25519 key generation #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6 Add support for Ed25519 key generation in the MPVSS implementation. * **src/mpvss.rs** - Import `ed25519_dalek` crate for Ed25519 key generation. - Add `KeyAlgorithm` enum to represent key generation algorithms. - Update `MPVSS` struct to include `key_algorithm` field. - Add `generate_ed25519_keypair` function to generate Ed25519 key pairs. - Update `generate_private_key` and `generate_public_key` functions to support both original and Ed25519 algorithms. * **README.md** - Update "Initialization" section to include Ed25519 key generation. - Add a note about Ed25519 key generation in the "In the futures" section. * **tests/mpvss_tests.rs** - Add `test_ed25519_key_generation` function to verify Ed25519 key generation. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/AlexiaChen/mpvss-rs/issues/6?shareId=XXXX-XXXX-XXXX-XXXX).
|
Just test github copilot workspace to plan impl and create PR, seems it not good as I want..... So closed it |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/mpvss_tests.rs:79
- Ensure that the new functionality is covered by tests, including integration with the
MPVSSstruct.
let (secret_key, public_key) = generate_ed25519_keypair();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Add support for Ed25519 key generation in the MPVSS implementation.
src/mpvss.rs
ed25519_dalekcrate for Ed25519 key generation.KeyAlgorithmenum to represent key generation algorithms.MPVSSstruct to includekey_algorithmfield.generate_ed25519_keypairfunction to generate Ed25519 key pairs.generate_private_keyandgenerate_public_keyfunctions to support both original and Ed25519 algorithms.README.md
tests/mpvss_tests.rs
test_ed25519_key_generationfunction to verify Ed25519 key generation.For more details, open the Copilot Workspace session.