Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light structure redundancy #8

Open
AlexandreLamure opened this issue Oct 15, 2019 · 2 comments
Open

Light structure redundancy #8

AlexandreLamure opened this issue Oct 15, 2019 · 2 comments
Assignees
@AlexandreLamure
Labels
enhancement New feature or request

Comments

@AlexandreLamure
Copy link
Owner

Avoid declaring the light structures (Material, DirLight, PointLight) in all.glsl.
@AlexandreLamure AlexandreLamure self-assigned this Oct 15, 2019
@AlexandreLamure
Copy link
Owner Author

It does not seem to be possible currently.
struct cannot be forward declared.
The best solution would be to merge compute_lights in all.glsl.

@AlexandreLamure AlexandreLamure added the enhancement New feature or request label Oct 16, 2019
@AlexandreLamure
Copy link
Owner Author

An other solution would be to edit the all.glsl file using C++ code.
Using this solution, we could also edit the preprocessor constants in compute-lights.glslto set variable length of array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandreLamure AlexandreLamure

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexandreLamure