Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanseru can skip pages #1

Open
Akenaide opened this issue Jan 31, 2021 · 1 comment
Open

Kanseru can skip pages #1

Akenaide opened this issue Jan 31, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right

Comments

@Akenaide
Copy link
Owner

for {
	select {
	case retryLink := <-retry:
		jobs <- retryLink
		log.Printf("Retry: %v", retryLink)
	default:
		jobs <- fmt.Sprintf("%v?page=%d", Baseurl, page)
		page = page + 1
	}

	if kanseru {
		log.Println("Kanseru at: ", page)
		break
	}
}

We should put a condition on the break.

@Akenaide Akenaide added the bug Something isn't working label Jan 31, 2021
@Akenaide
Copy link
Owner Author

Akenaide commented Jun 5, 2023

It can still appear, it's less frequent but still there. You can see LRC needed 2 runs to get all cards :
af9be2576338269ee5fc53521473f6a11d7dcb84
0b2eb11821b43808869e818f6b327d801af94a5e

Maybe we should rework all the goroutine logic.

@Akenaide Akenaide reopened this Jun 5, 2023
@Akenaide Akenaide added the help wanted Extra attention is needed label Jun 5, 2023
@Akenaide Akenaide added the invalid This doesn't seem right label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant