Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member variables ending with '_' are not required to have @private JsDoc when declared inside goog.scope. #75

Open
GoogleCodeExporter opened this issue Mar 31, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Check both attached files (fooNoGoogScope.js and fooWithGoogScope.js)

What is the expected output? What do you see instead?

Expected output is two errors:

----- FILE  :  /Users/me/fooNoGoogScope.js -----
Line 19, E:0221: Member "this.complain_" must have @private JsDoc.
----- FILE  :  /Users/me/fooWithGoogScope.js -----
Line 25, E:0221: Member "this.complain_" must have @private JsDoc.
Found 2 errors, including 0 new errors, in 2 files (0 files OK).

Actual output:

----- FILE  :  /Users/me/fooNoGoogScope.js -----
Line 19, E:0221: Member "this.complain_" must have @private JsDoc.

I would expect that goog.scope not to change the behavior of requiring @private 
on member variables that end with an underscore.

What version of the product are you using? On what operating system?

2.3.11, OS X 10.6

Please provide any additional information below.

The same error does not occur with declarations in the immediate scope of the 
goog.scope function.

Original issue reported on code.google.com by [email protected] on 3 Sep 2013 at 11:26

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant