-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type error upon calling payment-methods store-api (headless) as PaymentMethodRouteResponseSubscriber sets an object for an expected array #531
Comments
any news regarding this? |
Still an issue in 3.17 |
I did create a one line change PR that would fix this #532 Not sure why this still hasn't been merged, the PR exists for several months now and has basically no changes. |
Hi, Thank you for your patience. We are currently investigating the root cause of the issue you reported. Our team is working to identify and resolve it. We will keep you updated and notify you as soon as we have more information or a resolution to share. Best regards |
Hi, Thank you for your continued patience as we work on resolving this issue. Our team is still actively investigating the root cause and working towards a solution. We appreciate your understanding and will keep you updated with any progress or developments. If you have any additional information that might assist us, please feel free to share it. Best regards |
Additional information, see my PR: #532 that's everything that is needed to fix this (at least it was when I created the issue). |
Describe the bug
A clear and concise description of what the bug is.
Versions
Shopware version: 6.5.8.12
Plugin version: 3.16.0
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No type error and correct response.
Code info
At https://github.com/Adyen/adyen-shopware6/blob/3.16.0/src/Subscriber/Response/PaymentMethodRouteResponseSubscriber.php#L163
you return now null or a PaymentMethod object. which is then set https://github.com/Adyen/adyen-shopware6/blob/3.16.0/src/Subscriber/Response/PaymentMethodRouteResponseSubscriber.php#L148C29-L148C51 to an array. this results in a type error.
potentialy solutions:
The text was updated successfully, but these errors were encountered: