Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 implicit nullable variables #715

Open
BertvanHoekelen opened this issue Dec 2, 2024 · 1 comment
Open

PHP 8.4 implicit nullable variables #715

BertvanHoekelen opened this issue Dec 2, 2024 · 1 comment

Comments

@BertvanHoekelen
Copy link

Describe the bug
In PHP 8.4 implicitly marking parameters null is deprecated. So I get a bunch of deprecation notices.

PHP Deprecated:  Adyen\Config::__construct(): Implicitly marking parameter $params as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Config.php on line 37
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::cancelAuthorisedPayment(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 50
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::cancelAuthorisedPaymentByPspReference(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 66
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::captureAuthorisedPayment(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 82
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::refundCapturedPayment(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 98
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::refundOrCancelPayment(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 114
PHP Deprecated:  Adyen\Service\Checkout\ModificationsApi::updateAuthorisedAmount(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/ModificationsApi.php on line 130
PHP Deprecated:  Adyen\Service::requestHttp(): Implicitly marking parameter $bodyParams as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service.php on line 55
PHP Deprecated:  Adyen\Service::requestHttp(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service.php on line 55
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::cardDetails(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 50
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::getResultOfPaymentSession(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 65
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::paymentMethods(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 80
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::payments(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 95
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::paymentsDetails(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 110
PHP Deprecated:  Adyen\Service\Checkout\PaymentsApi::sessions(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/PaymentsApi.php on line 125
PHP Deprecated:  Adyen\Service\Checkout\RecurringApi::deleteTokenForStoredPaymentDetails(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/RecurringApi.php on line 50
PHP Deprecated:  Adyen\Service\Checkout\RecurringApi::getTokensForStoredPaymentDetails(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/RecurringApi.php on line 63
PHP Deprecated:  Adyen\Service\Checkout\RecurringApi::storedPaymentMethods(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Checkout/RecurringApi.php on line 78
PHP Deprecated:  Adyen\Service\Payout\InitializationApi::storeDetail(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Payout/InitializationApi.php on line 50
PHP Deprecated:  Adyen\Service\Payout\InitializationApi::storeDetailAndSubmitThirdParty(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Payout/InitializationApi.php on line 65
PHP Deprecated:  Adyen\Service\Payout\InitializationApi::submitThirdParty(): Implicitly marking parameter $requestOptions as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/adyen/php-api-library/src/Adyen/Service/Payout/InitializationApi.php on line 80

To Reproduce
Steps to reproduce the behavior:

  1. Install library in a new PHP 8.4 environment
  2. Do anything with the library

Expected behavior
Don't have any deprecation notices.

Additional context
I could open a PR fixing it except these classes seem auto generated. So before I spent time creating a PR I want to verify with you.

@coajaxial
Copy link

Would be great if this could be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants