Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-nullable billingToken issue for non-recurring PayPal payments #664

Closed
emnsen opened this issue Jun 10, 2024 · 7 comments
Closed

Non-nullable billingToken issue for non-recurring PayPal payments #664

emnsen opened this issue Jun 10, 2024 · 7 comments

Comments

@emnsen
Copy link

emnsen commented Jun 10, 2024

Hi all,

Describe the bug
My issue is related to PaymentCompletionDetails.php#L539. I don't have anything to do with recurring payment and even in the documentation it says It's for the recurring payment, but the code doesn't allow me to continue my process.

Screenshots
This is the payload that I got.
Payload

Expected behavior
Billing token should be nullable

@jillingk
Copy link
Contributor

Hey @emnsen,

Thanks for reaching out here. What library version are you on? I remember we fixed this issue with nullables in the past at some point.

Best, Jilling
Adyen

@emnsen
Copy link
Author

emnsen commented Jun 10, 2024

Hey @jillingk

I'm using v18.1.0.

@jillingk
Copy link
Contributor

@emnsen,

Ah my bad I see this is a string field, the fix I was thinking about was for bools.

Thanks for the contribution, however these models are auto generated based on templates and hence we should modify it there. I'll make sure we will do this asap.

Best, Jilling
Adyen

@emnsen
Copy link
Author

emnsen commented Jun 19, 2024

Hey @jillingk
Would it be possible to share any timeline for when this fix will happen?

@emnsen
Copy link
Author

emnsen commented Jun 25, 2024

Hello, anyone? Can someone give me an answer, please?

@jillingk
Copy link
Contributor

Hi @emnsen,

Very sorry for the slow response! I've just opened a PR to fix your issue. We should have this released this week :)

Best, Jilling
Adyen

@DjoykeAbyah
Copy link
Member

Hi @emnsen!

I just wanted to quickly update you that the fix has been released!

Regards,

Djoyke
Adyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants