Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make this library not suck? #661

Closed
fortytwofortyone opened this issue Jun 1, 2024 · 1 comment
Closed

Can you make this library not suck? #661

fortytwofortyone opened this issue Jun 1, 2024 · 1 comment

Comments

@fortytwofortyone
Copy link

fortytwofortyone commented Jun 1, 2024

Is your feature request related to a problem? Please describe.
Yes, parameterize all functions so you don't have to guess what should be in $params. Make the code actually readable instead of this type of loose sand. This does not simplify using Adyen over any framework HTTPClient. Actually use your head when you design these libraries.

For instance here is an example.

public function getConnectedTerminals($params) //pure shit, don't know what to pass, have to look for obfuscated API docs online where 5 pages describe the terminal API but only one of those tells you which parameters you need.

public function getConnectedTerminals(string $merchant, string $store = '', string $terminalId = '') ) // clear and error proof interface that does not suck.

Automation / libraries should make things easier, not just the same level of hard in a different way. You should be ashamed.

@jillingk
Copy link
Contributor

jillingk commented Jun 3, 2024

Hi @fortytwofortyone,

Thanks for reaching out here and I'm very sorry to hear you experience with this library has been suboptimal. Do note that this is a bit of and older part of the library (one that we have not automated yet) which meant it's a bit simpler implementation-wise to say the least. We will do our best to revise it anytime soon! In the meantime please let us know if you run into anything else.

Best, Jilling
Adyen

@DjoykeAbyah DjoykeAbyah changed the title Can you make this library not suck? ECP-9268: Can you make this library not suck? Jun 6, 2024
@DjoykeAbyah DjoykeAbyah changed the title ECP-9268: Can you make this library not suck? Can you make this library not suck? Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants