RecurringApi::deleteTokenForStoredPaymentDetails call fails even though the request is correctly performed and successfully finished

[vasilake-v]

Describe the bug
Call to \Adyen\Service\Checkout\RecurringApi::deleteTokenForStoredPaymentDetails fails with TypeError: Return value must be of type array, string returned, although the request is finished successful

Delete payment method returns empty response with 204 code. That means, the same empty result is returned by Adyen\HttpClient\CurlClient::requestHttp() (empty string or null depending on outputType in config).

Because Adyen\Service::requestHttp() directly returns result of previously mentioned method, it fails because Adyen\Service::requestHttp(): array (has a strict return type array)

To Reproduce
Steps to reproduce the behavior:

1. Perform a call to \Adyen\Service\Checkout\RecurringApi::deleteTokenForStoredPaymentDetails with usual arguments

Expected behavior
Either return empty array, success result dto, or at least no error :)

Additional context
Add any other context about the problem here.
Currently we are at package version: v15.4.0. Although there is a newer version the package, the requestHttp() method is similar

[michaelpaul]

Hello @vasilake-v, thanks for reporting this issue! A fix shall be released soon on our next major.

[vasilake-v]

@michaelpaul thanks for taking care about this. Do you think we could replicate/have similar fix for previous major version ?
So we also allow other package users (still using lower version) to benefit from functionality, while still following their own timetable for smooth migration plan from Arrays -> DTOs ( instead of rushing and repriotize other things for upgrading to the new major version, only for this fix)

I can port the fix on the v15 and prepare a pull request

[michaelpaul]

Hey @vasilake-v, we understand that upgrading to a major version can be complicated, so we've ported the fix to v15. Now you can find it on v15.5.1.

[vasilake-v]

@michaelpaul Thank you! 👍