Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API response not correctly handled #490

Closed
thedigital opened this issue Apr 14, 2023 · 2 comments
Closed

API response not correctly handled #490

thedigital opened this issue Apr 14, 2023 · 2 comments

Comments

@thedigital
Copy link

Describe the bug
From branch #489
When trying to update Apple Pay domains, it always gives this error : Probably your Web Service username and/or password is incorrect
(Network error [errno 0]: )
But it did work as you can see in Adyen api logs : https://ca-test.adyen.com/ca/ca/api/logdetails.shtml?logID=APIL4224Q22322595HPHJR2BJ25458

To Reproduce
Steps to reproduce the behavior:

  1. Use code from the pull request : Add MerchantAccount.addApplePayDomains #489
  2. Call $service->merchantAccount->addApplePayDomains($merchantId, $paymentMethodId, ['domains' => [...]'])
  3. See error in response after call
  4. See "accepted" response in Adyen api logs

Expected behavior
Succesful response

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

@jillingk
Copy link
Contributor

Hi @thedigital,

Thanks for reaching out to us and making the contributions! It's highly appreciated. The issue you're seeing will actually be fixed by #464 (basically the client would always throw an error for an empty response body, even though you would expect that in for example DELETE request or in this case the POST with empty response body).

Best, Jilling
Adyen

@thedigital
Copy link
Author

Hi Jilling

Ok thank you for your answer ! Nothing to add :)

Good day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants