Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Google pay methods in ManualCapture #438

Closed
maaarghk opened this issue Feb 8, 2023 · 6 comments
Closed

Missing Google pay methods in ManualCapture #438

maaarghk opened this issue Feb 8, 2023 · 6 comments

Comments

@maaarghk
Copy link

maaarghk commented Feb 8, 2023

Incorrect false result in Adyen\Util\ManualCapture::isManualCaptureSupported for visa_googlepay and mc_googlepay (possibly others)

Update: Visa and mc are there but these others appear in our account and not in this list:

        'amex_googlepay',
        'discover_googlepay',
        'maestro_googlepay',

(unless they don't support manual capture but I don't believe that is the case)

@maaarghk
Copy link
Author

maaarghk commented Mar 7, 2023

@wboereboom pls :(

@maaarghk
Copy link
Author

@jillingk did you note the update edited into the first post - there are still missing variants, this does not appear to be complete unless you have a PR not yet pushed

@jillingk
Copy link
Contributor

@maaarghk,

My bad! I got that all the variants were added by now. I'll take a look into it right now.

Best, Jilling
Adyen

@jillingk jillingk reopened this Mar 27, 2023
@maaarghk
Copy link
Author

@jillingk I notice this file was updated in #458 but the other google pay variants are still not added

@maaarghk
Copy link
Author

cc @carlosperales95

carlosperales95 pushed a commit to carlosperales95/adyen-php-api-library that referenced this issue May 1, 2023
@carlosperales95
Copy link
Contributor

#499

wboereboom added a commit that referenced this issue May 5, 2023
Added other missing variants as per #438
@jillingk jillingk closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants