[ECP-9225] Use Magento_Tax module to build open invoice line items #2651
+120
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obtain amount including tax related values
RokPopov
commented
Jun 10, 2024
candemiralp
changed the title
|
khushboo-singhvi
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After multiple attempts of addressing the issues with open invoice line items not reflecting the correct values, the idea behind this PR is to deprecate the methods in the plugin responsible for tax line item calculations and use Magento_Tax module to get display prices instead.
Tested scenarios
Different tax configurations:
Fixes #2580